Remove the cache_time_info option

The new time info caching behaviour supersedes this by getting rid of
callbacks altogether.

src/common/configuration.cpp

@@ -84,12 +84,6 @@ Configuration::Configuration(const fs::path& config_path,
                 } else {
                     invalid_options.push_back(key);
                 }
-            } else if (key == "cache_time_info") {
-                if (const auto parsed_value = value.as_boolean()) {
-                    cache_time_info = parsed_value->get();
-                } else {
-                    invalid_options.push_back(key);
-                }
             } else if (key == "editor_double_embed") {
                 if (const auto parsed_value = value.as_boolean()) {
                     editor_double_embed = parsed_value->get();

src/common/configuration.h

@@ -81,20 +81,6 @@ class Configuration {
      */
     std::optional<std::string> group;
 
-    /**
-     * If set to `true`, then after an `audioMasterGetTime()` call all
-     * subsequent calls to that function during a single processing cycle will
-     * reuse the results from the first call. In theory it would be a bug on the
-     * host's side if this did _not_ return the same value every time, but since
-     * yabridge tries to not have any behaviour of its own and since this
-     * function should only be called at most once every processing cycle this
-     * option is not enabled by default. An example of a situation where this
-     * does become necessary is the SWAM Cello plugin, which calls
-     * `audioMasterGetTime()` for every sample instead of only once. This would
-     * tank performance without this caching behaviour.
-     */
-    bool cache_time_info = false;
-
     /**
      * If this is set to `true`, then the plugin editor should be embedded in
      * yet another window. This would result in an embedding sequence of
@@ -201,7 +187,6 @@ class Configuration {
         s.ext(group, bitsery::ext::StdOptional(),
               [](S& s, auto& v) { s.text1b(v, 4096); });
 
-        s.value1b(cache_time_info);
         s.value1b(editor_double_embed);
         s.value1b(editor_force_dnd);
         s.value1b(editor_xembed);

src/plugin/bridges/common.h

@@ -175,9 +175,6 @@ class PluginBridge {
 
         init_msg << "other options: ";
         std::vector<std::string> other_options;
-        if (config.cache_time_info) {
-            other_options.push_back("hack: time info cache");
-        }
         if (config.editor_double_embed) {
             other_options.push_back("editor: double embed");
         }