vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-14 12:30:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix uninitialized seek position in VectorStream

Browse Source
This commit is contained in:
Robbert van der Helm
2020-12-18 12:52:05 +01:00
parent 8066e1d2ee
commit 381ca253c1
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst3/base.cpp
+7 -9
View File
@@ -193,7 +193,7 @@ VectorStream::VectorStream(Steinberg::IBStream* stream) {
int64 size;
assert(stream->tell(&size) == Steinberg::kResultOk);
int32 num_bytes_read;
int32 num_bytes_read = 0;
buffer.resize(size);
assert(stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekSet) ==
Steinberg::kResultOk);
@@ -227,14 +227,12 @@ tresult VectorStream::write_back(Steinberg::IBStream* stream) const {
return Steinberg::kInvalidArgument;
}
int32 num_bytes_written;
int32 num_bytes_written = 0;
assert(stream->seek(0, kIBSeekSet) == Steinberg::kResultOk);
// When writing zero bytes, some hosts will return `kResultFalse`
if (stream->write(const_cast<uint8_t*>(buffer.data()), buffer.size(),
&num_bytes_written) == Steinberg::kResultOk) {
assert(num_bytes_written == 0 ||
static_cast<size_t>(num_bytes_written) == buffer.size());
}
assert(stream->write(const_cast<uint8_t*>(buffer.data()), buffer.size(),
&num_bytes_written) == Steinberg::kResultOk);
assert(num_bytes_written == 0 ||
static_cast<size_t>(num_bytes_written) == buffer.size());
return Steinberg::kResultOk;
}
@@ -276,7 +274,7 @@ tresult PLUGIN_API VectorStream::write(void* buffer,
}
std::copy_n(reinterpret_cast<uint8_t*>(buffer), numBytes,
&this->buffer[seek_position]);
this->buffer.begin() + seek_position);
seek_position += numBytes;
if (numBytesWritten) {
src/common/serialization/vst3/base.h
+1 -1
View File
@@ -225,7 +225,7 @@ class VectorStream : public Steinberg::IBStream,
private:
std::vector<uint8_t> buffer;
size_t seek_position;
size_t seek_position = 0;
};
#pragma GCC diagnostic pop