From 2a2ff6bd2a96244084e032c1c31aa984df5ec316 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Fri, 6 Mar 2020 15:56:24 +0100 Subject: [PATCH] Add a note on concurrency to the logger --- src/common/logging.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/common/logging.h b/src/common/logging.h index 8a357a2a..111b0fc3 100644 --- a/src/common/logging.h +++ b/src/common/logging.h @@ -40,6 +40,12 @@ constexpr char logging_verbosity_environment_variable[] = * plugins. This is also used to redirect the output of the Wine process * because DAWs like Bitwig hide this from you, making it hard to debug * crashing plugins. + * + * @note This does not do any synchronisation. While this should technically + * be causing problems in concurrent use, writing strings to fstreams from + * multiple threads at the same time doesn't seem to produce corrupted text if + * you're writing an entire string at once even though the messages may be + * slightly out of order. */ class Logger { public: