vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change VST3 SDK patching to apply handwritten diff

Browse Source 
Instead of replacing things with sed. This was a bit brittle with the
changes in 3.7.6/3.7.7, and this approach keeps compatibility with older
SDK versions.
This commit is contained in:
Robbert van der Helm
2022-12-23 18:20:25 +01:00
parent 5150332d20
commit 2984b1d26f
7 changed files with 2640 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/patch-vst3-sdk.sh
+34 -61
View File
@@ -8,74 +8,47 @@
# rather not have to do this.
#
# Usage:
# patch-vst3-sdk.sh <sdk_directory>
# patch-vst3-sdk.sh <sdk_directory> [sdk_version]
set -euo pipefail
sdk_directory=$1
if [[ -z $sdk_directory ]]; then
echo "Usage:"
echo "patch-vst3-sdk.sh <sdk_directory>"
version=${2:-}
if [[ ! -d $sdk_directory ]]; then
echo >&2 "Usage:"
echo >&2 "patch-vst3-sdk.sh <sdk_directory> [sdk_version]"
echo >&2
echo >&2 "The version is parsed from the from the CMakeLists.txt file if omitted."
exit 1
fi
# Use the proper libc functions instead of the MSVC intrinsics. These are also
# used in `fstring.cpp`, but there we will patch the entire file to use the
# standard POSIX/GCC string formatting facilities.
sed -i 's/\b_vsnprintf\b/vsnprintf/g;s/\b_snprintf\b/snprintf/g' "$sdk_directory/base/source/fdebug.cpp"
if [[ -z $version ]]; then
# `-z` is a quick way to search across multiple lines in case they format
# future versions differently, and the combination of `-n`, `p`, and replacing
# everything before and after the version causes this to print nothing if the
# replacement didn't succeed
version=$(sed -zn 's/.*project(vstsdk\s*VERSION \([0-9.]\+\).*/\1/ p' "$sdk_directory/CMakeLists.txt")
fi
# Use the attributes and types from GCC
sed -i 's/defined(__MINGW32__)/defined(__WINE__)/g' "$sdk_directory/pluginterfaces/base/ftypes.h"
if [[ -z $version ]]; then
echo >&2 "Could not parse the VST3 SDK version from '$sdk_directory/CMakeLists.txt'"
exit 1
fi
# There are some more places where the SDK includes better compatibility with
# GCC that we can use
# NOTE: We should **not** define __MINGW32__ globally, since that also breaks
# Wine's headers in headache inducing ways
sed -i 's/defined(__MINGW32__)/defined(__WINE__)/g' "$sdk_directory/public.sdk/source/common/systemclipboard_win32.cpp"
patch_file=$(dirname "$0")/vst3-sdk-patches/vst3-sdk-patch-$version.diff
if [[ ! -f $patch_file ]]; then
echo >&2 "The patch file for this SDK version ('$patch_file') does not yet exist"
exit 1
fi
# Use the string manipulation functions from the C standard library
sed -i 's/\bSMTG_OS_WINDOWS\b/0/g;s/\bSMTG_OS_LINUX\b/1/g' "$sdk_directory/base/source/fstring.cpp"
sed -i 's/\bSMTG_OS_WINDOWS\b/0/g;s/\bSMTG_OS_LINUX\b/1/g' "$sdk_directory/pluginterfaces/base/fstrdefs.h"
sed -i 's/\bSMTG_OS_WINDOWS\b/0/g;s/\bSMTG_OS_LINUX\b/1/g' "$sdk_directory/pluginterfaces/base/ustring.cpp"
# `Windows.h` expects `wchar_t`, and the above defines will cause us to use
# `char16_t` for string literals. This replacement targets a very specific line,
# so if the SDK gets updated, this fails, and we're getting a ton of `wchar_t`
# related compile errors, that's why. The previous sed call will have replaced
# `SMTG_OS_WINDOWS` with a 0 here.
sed -i 's/^ #if 0$/ #if __WINE__/' "$sdk_directory/pluginterfaces/base/fstrdefs.h"
# We'll need some careful replacements in the Linux definitions in `fstring.cpp`
# to use `wchar_t` instead of `char16_t`.
replace_char16() {
local needle=$1
local filename=$2
wchar_version=${needle//char16_t/wchar_t}
sed -i "s/^$needle$/#ifdef __WINE__\\
$wchar_version\\
#else\\
\0\\
#endif/" "$filename"
}
replace_char16 "using ConverterFacet = std::codecvt_utf8_utf16<char16_t>;" "$sdk_directory/base/source/fstring.cpp"
replace_char16 "using Converter = std::wstring_convert<ConverterFacet, char16_t>;" "$sdk_directory/base/source/fstring.cpp"
replace_char16 "using Converter = std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t>;" "$sdk_directory/pluginterfaces/base/ustring.cpp"
# Don't try adding `std::u8string` to an `std::vector<std::string>`. MSVC
# probably coerces them, but GCC doesn't
sed -i 's/\bgeneric_u8string\b/generic_string/g' "$sdk_directory/public.sdk/source/vst/hosting/module_win32.cpp"
# libstdc++fs doesn't work under Winelib, for whatever reason that might be.
# We'll patch the Win32 module loading to use `ghc::filesystem` instead.
sed -i 's/^#include <\(experimental\/\)\?filesystem>$/#include <ghc\/filesystem.hpp>/' "$sdk_directory/public.sdk/source/vst/hosting/module_win32.cpp"
sed -i 's/^namespace filesystem = std\(::experimental\)\?::filesystem;$/namespace filesystem = ghc::filesystem;/' "$sdk_directory/public.sdk/source/vst/hosting/module_win32.cpp"
# Wine uses the narrow versions of everything by default, and in Unity builds
# we need to explicitly use the UTF-16 version here.
sed -i 's/\bIShellLink\*/IShellLinkW*/g' "$sdk_directory/public.sdk/source/vst/hosting/module_win32.cpp"
# Meson requires this program to output something, or else it will error out
# when trying to encode the empty output
echo "Successfully patched '$sdk_directory' for winegcc compatibility"
# Patch either automatically reverses already applied patches, or throws errors
# when the patch has already been applied and you tell it to not reverse
# patches. So we'll check whether the patch has already been applied first.
if ! patch -d "$sdk_directory" -p1 -f --dry-run --reverse <"$patch_file" >/dev/null 2>&1; then
patch -d "$sdk_directory" -p1 -f --forward <"$patch_file"
echo -e "\nSuccessfully patched '$sdk_directory' for Winelib compatibility"
else
# Meson requires this program to output something, or else it will error out
# when trying to encode the empty output
echo "'$sdk_directory' has already been patched for Winelib compatibility, ignoring..."
fi