From 28013cb6a770b25378974366515f1c925d0f040e Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Fri, 20 Nov 2020 15:59:40 +0100 Subject: [PATCH] Note that the effEditIdle issue is fixed in Ardour For the upcoming Ardour 6.4 release: https://github.com/Ardour/ardour/commit/f7cb1b0b481eeda755bdf8eb9fc5f90a81d2aa01 --- src/wine-host/bridges/vst2.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/wine-host/bridges/vst2.cpp b/src/wine-host/bridges/vst2.cpp index 8fc30599..d60b6a9d 100644 --- a/src/wine-host/bridges/vst2.cpp +++ b/src/wine-host/bridges/vst2.cpp @@ -300,8 +300,10 @@ void Vst2Bridge::handle_dispatch() { void* data, float option) -> intptr_t { // HACK: Ardour 6.3 will call `effEditIdle` before // `effEditOpen`, which causes some plugins to - // crash. This should be reported to Ardour's - // issue tracker. + // crash. This has been fixed as of + // https://github.com/Ardour/ardour/commit/f7cb1b0b481eeda755bdf8eb9fc5f90a81d2aa01. + // We should keep this in until Ardour 6.3 is no + // longer in distro's repositories. if (opcode == effEditIdle && !editor) { std::cerr << "WARNING: The host is calling " "`effEditIdle()` while the "