Implement IComponentHandler::endEdit()

src/common/logging/vst3.cpp

@@ -463,6 +463,14 @@ bool Vst3Logger::log_request(bool is_host_vst,
     });
 }
 
+bool Vst3Logger::log_request(bool is_host_vst,
+                             const YaComponentHandler::EndEdit& request) {
+    return log_request_base(is_host_vst, [&](auto& message) {
+        message << request.owner_instance_id
+                << ": IComponentHandler::endEdit(id = " << request.id << ")";
+    });
+}
+
 void Vst3Logger::log_response(bool is_host_vst, const Ack&) {
     log_response_base(is_host_vst, [&](auto& message) { message << "ACK"; });
 }

src/common/logging/vst3.h

@@ -112,6 +112,7 @@ class Vst3Logger {
     bool log_request(bool is_host_vst, const WantsConfiguration&);
     bool log_request(bool is_host_vst, const YaComponentHandler::BeginEdit&);
     bool log_request(bool is_host_vst, const YaComponentHandler::PerformEdit&);
+    bool log_request(bool is_host_vst, const YaComponentHandler::EndEdit&);
 
     void log_response(bool is_host_vst, const Ack&);
     void log_response(

src/common/serialization/vst3.h

@@ -107,7 +107,8 @@ void serialize(S& s, ControlRequest& payload) {
  */
 using CallbackRequest = std::variant<WantsConfiguration,
                                      YaComponentHandler::BeginEdit,
-                                     YaComponentHandler::PerformEdit>;
+                                     YaComponentHandler::PerformEdit,
+                                     YaComponentHandler::EndEdit>;
 
 template <typename S>
 void serialize(S& s, CallbackRequest& payload) {

src/common/serialization/vst3/component-handler/component-handler.h

@@ -105,6 +105,25 @@ class YaComponentHandler : public Steinberg::Vst::IComponentHandler {
     virtual tresult PLUGIN_API
     performEdit(Steinberg::Vst::ParamID id,
                 Steinberg::Vst::ParamValue valueNormalized) override = 0;
+
+    /**
+     * Message to pass through a call to `IComponentHandler::endEdit(id)` to the
+     * component handler provided by the host.
+     */
+    struct EndEdit {
+        using Response = UniversalTResult;
+
+        native_size_t owner_instance_id;
+
+        Steinberg::Vst::ParamID id;
+
+        template <typename S>
+        void serialize(S& s) {
+            s.value8b(owner_instance_id);
+            s.value4b(id);
+        }
+    };
+
     virtual tresult PLUGIN_API endEdit(Steinberg::Vst::ParamID id) override = 0;
     virtual tresult PLUGIN_API restartComponent(int32 flags) override = 0;
 

src/plugin/bridges/vst3.cpp

@@ -96,6 +96,12 @@ Vst3PluginBridge::Vst3PluginBridge()
                         .component_handler->performEdit(
                             request.id, request.value_normalized);
                 },
+                [&](const YaComponentHandler::EndEdit& request)
+                    -> YaComponentHandler::EndEdit::Response {
+                    return plugin_proxies.at(request.owner_instance_id)
+                        .get()
+                        .component_handler->endEdit(request.id);
+                },
             });
     });
 }

src/wine-host/bridges/vst3-impls/component-handler-proxy.cpp

@@ -56,9 +56,8 @@ tresult PLUGIN_API Vst3ComponentHandlerProxyImpl::performEdit(
 
 tresult PLUGIN_API
 Vst3ComponentHandlerProxyImpl::endEdit(Steinberg::Vst::ParamID id) {
-    // TODO: Implement
+    return bridge.send_message(YaComponentHandler::EndEdit{
-    std::cerr << "TODO: IComponentHandler::endEdit()" << std::endl;
+        .owner_instance_id = owner_instance_id(), .id = id});
-    return Steinberg::kNotImplemented;
 }
 
 tresult PLUGIN_API