vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Get rid of the string conversion patch

Browse Source 
This solved some compiler errors early on but it ended up not being
needed, and as it turns out this change actually breaks things because
the SDK uses a ton of reinterpret casts to convert between string types
internally.
This commit is contained in:
Robbert van der Helm
2020-12-02 19:08:11 +01:00
parent 8381b4a836
commit 211f6156a7
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/patch-vst3-sdk.sh
-9
View File
@@ -63,15 +63,6 @@ replace_char16 "using Converter = std::wstring_convert<std::codecvt_utf8_utf16<c
# version here is trying to do something funky
sed -i 's/\b__MINGW32__\b/__NOPE__/g' "$sdk_directory/pluginterfaces/base/funknown.cpp"
# The string conversion functions in the VST3 SDK itself are not mingw aware and
# will thus use the wrong string types since we're not compiling with MSVC
# TODO: Figure out if this is actually needed
sed -i 's/^#if defined(_MSC_VER) && .\+$/#if __WINE__/' "$sdk_directory/public.sdk/source/vst/utility/stringconvert.cpp"
# Use the proper `<filesystem>` header instead of the experimental one
# TODO: Check if <filesystem> now works with Winelib, or replace with Boost
# sed -i 's/^#if _HAS_CXX17 && defined(_MSC_VER)$/#if 1/' "$sdk_directory/public.sdk/source/vst/hosting/module_win32.cpp"
# Don't try adding `std::u8string` to an `std::vector<std::string>`. MSVC
# probably coerces them, but GCC doesn't
sed -i 's/\bgeneric_u8string\b/generic_string/g' "$sdk_directory/public.sdk/source/vst/hosting/module_win32.cpp"