vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 12:10:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't serialize input info for IEditController::getParameterInfo

Browse Source
This commit is contained in:
Robbert van der Helm
2021-02-12 19:01:19 +01:00
parent 5978247a0b
commit 2020acfec1
4 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin/bridges/vst3-impls/plugin-proxy.cpp
+4 -5
View File
@@ -490,7 +490,7 @@ tresult PLUGIN_API Vst3PluginProxyImpl::getParameterInfo(
int32 paramIndex,
Steinberg::Vst::ParameterInfo& info /*out*/) {
const auto request = YaEditController::GetParameterInfo{
.instance_id = instance_id(), .param_index = paramIndex, .info = info};
.instance_id = instance_id(), .param_index = paramIndex};
// We'll cache this information to work around an issue in REAPER, see
// `parameter_info_cache`
@@ -503,8 +503,7 @@ tresult PLUGIN_API Vst3PluginProxyImpl::getParameterInfo(
bridge.logger.log_response(
true,
YaEditController::GetParameterInfo::Response{
.result = Steinberg::kResultOk,
.updated_info = it->second},
.result = Steinberg::kResultOk, .info = it->second},
true);
}
@@ -516,11 +515,11 @@ tresult PLUGIN_API Vst3PluginProxyImpl::getParameterInfo(
const GetParameterInfoResponse response = bridge.send_message(request);
info = response.updated_info;
info = response.info;
{
std::lock_guard lock(parameter_info_cache_mutex);
parameter_info_cache.parameter_info[paramIndex] = response.updated_info;
parameter_info_cache.parameter_info[paramIndex] = response.info;
}
return response.result;