Fully implement IComponentHandlerBusActivation

We now support all VST 3.6.8 features. (or technically, also all VST
3.6.10 features)
This commit is contained in:
Robbert van der Helm
2021-01-14 16:42:19 +01:00
parent d9d508a47e
commit 1d9b60b481
5 changed files with 48 additions and 29 deletions
+3 -1
View File
@@ -180,7 +180,8 @@ void serialize(S& s, AudioProcessorRequest& payload) {
* information we want or the operation we want to perform. A request of type * information we want or the operation we want to perform. A request of type
* `CallbackRequest(T)` should send back a `T::Response`. * `CallbackRequest(T)` should send back a `T::Response`.
*/ */
using CallbackRequest = std::variant<Vst3ContextMenuProxy::Destruct, using CallbackRequest =
std::variant<Vst3ContextMenuProxy::Destruct,
WantsConfiguration, WantsConfiguration,
YaComponentHandler::BeginEdit, YaComponentHandler::BeginEdit,
YaComponentHandler::PerformEdit, YaComponentHandler::PerformEdit,
@@ -191,6 +192,7 @@ using CallbackRequest = std::variant<Vst3ContextMenuProxy::Destruct,
YaComponentHandler2::StartGroupEdit, YaComponentHandler2::StartGroupEdit,
YaComponentHandler2::FinishGroupEdit, YaComponentHandler2::FinishGroupEdit,
YaComponentHandler3::CreateContextMenu, YaComponentHandler3::CreateContextMenu,
YaComponentHandlerBusActivation::RequestBusActivation,
// Used when the host uses proxy objects, // Used when the host uses proxy objects,
// and we have to route // and we have to route
// `IConnectionPoint::notify` calls through // `IConnectionPoint::notify` calls through
@@ -449,6 +449,7 @@ tresult PLUGIN_API Vst3PluginProxyImpl::setComponentHandler(
// callback later // callback later
component_handler_2 = component_handler; component_handler_2 = component_handler;
component_handler_3 = component_handler; component_handler_3 = component_handler;
component_handler_bus_activation = component_handler;
unit_handler = component_handler; unit_handler = component_handler;
unit_handler_2 = component_handler; unit_handler_2 = component_handler;
@@ -334,6 +334,8 @@ class Vst3PluginProxyImpl : public Vst3PluginProxy {
component_handler_2; component_handler_2;
Steinberg::FUnknownPtr<Steinberg::Vst::IComponentHandler3> Steinberg::FUnknownPtr<Steinberg::Vst::IComponentHandler3>
component_handler_3; component_handler_3;
Steinberg::FUnknownPtr<Steinberg::Vst::IComponentHandlerBusActivation>
component_handler_bus_activation;
Steinberg::FUnknownPtr<Steinberg::Vst::IUnitHandler> unit_handler; Steinberg::FUnknownPtr<Steinberg::Vst::IUnitHandler> unit_handler;
Steinberg::FUnknownPtr<Steinberg::Vst::IUnitHandler2> unit_handler_2; Steinberg::FUnknownPtr<Steinberg::Vst::IUnitHandler2> unit_handler_2;
+11
View File
@@ -149,6 +149,17 @@ Vst3PluginBridge::Vst3PluginBridge()
.context_menu_args = std::nullopt}; .context_menu_args = std::nullopt};
} }
}, },
[&](const YaComponentHandlerBusActivation::RequestBusActivation&
request) -> YaComponentHandlerBusActivation::
RequestBusActivation::Response {
return plugin_proxies
.at(request.owner_instance_id)
.get()
.component_handler_bus_activation
->requestBusActivation(
request.type, request.dir,
request.index, request.state);
},
[&](const YaContextMenu::GetItemCount& request) [&](const YaContextMenu::GetItemCount& request)
-> YaContextMenu::GetItemCount::Response { -> YaContextMenu::GetItemCount::Response {
return plugin_proxies.at(request.owner_instance_id) return plugin_proxies.at(request.owner_instance_id)
@@ -119,10 +119,13 @@ tresult PLUGIN_API Vst3ComponentHandlerProxyImpl::requestBusActivation(
Steinberg::Vst::BusDirection dir, Steinberg::Vst::BusDirection dir,
int32 index, int32 index,
TBool state) { TBool state) {
// TODO: Implement return bridge.send_message(
std::cerr << "TODO: IComponentHandlerBusActivation::requestBusActivation()" YaComponentHandlerBusActivation::RequestBusActivation{
<< std::endl; .owner_instance_id = owner_instance_id(),
return Steinberg::kNotImplemented; .type = type,
.dir = dir,
.index = index,
.state = state});
} }
tresult PLUGIN_API Vst3ComponentHandlerProxyImpl::notifyUnitSelection( tresult PLUGIN_API Vst3ComponentHandlerProxyImpl::notifyUnitSelection(