vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add note to input focus grabbing

Browse Source 
This shouldn't be necessary for VST3, but it is.
This commit is contained in:
Robbert van der Helm
2020-12-21 22:46:59 +01:00
parent 063b480fd0
commit 1aa5d5d8b4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/editor.cpp
+4 -4
View File
@@ -346,10 +346,10 @@ void Editor::set_input_focus(bool grab) const {
// back to that window when the user moves their mouse outside of the Wine // back to that window when the user moves their mouse outside of the Wine
// window while the host's window is still active (that's an important // window while the host's window is still active (that's an important
// detail, since plugins may have dialogs). // detail, since plugins may have dialogs).
// FIXME: This should not be done for VST3 plugins since keyboard handling // XXX: In theory we wouldn't have to do this for VST3 because
// is part of `IPlugView`. Or at least, that's the idea. We have to // `IPlugView::onKey{Down,Up}` should handle all keyboard events. But
// figure out if plugins (and especially text input in things like // in practice a lot of hosts don't use that, so we still need to grab
// FabFilter plugins) work without this. // focus ourselves.
xcb_set_input_focus(x11_connection.get(), XCB_INPUT_FOCUS_PARENT, xcb_set_input_focus(x11_connection.get(), XCB_INPUT_FOCUS_PARENT,
grab ? parent_window : topmost_window, grab ? parent_window : topmost_window,
XCB_CURRENT_TIME); XCB_CURRENT_TIME);