mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-07 03:50:11 +02:00
Add note to input focus grabbing
This shouldn't be necessary for VST3, but it is.
This commit is contained in:
@@ -346,10 +346,10 @@ void Editor::set_input_focus(bool grab) const {
|
||||
// back to that window when the user moves their mouse outside of the Wine
|
||||
// window while the host's window is still active (that's an important
|
||||
// detail, since plugins may have dialogs).
|
||||
// FIXME: This should not be done for VST3 plugins since keyboard handling
|
||||
// is part of `IPlugView`. Or at least, that's the idea. We have to
|
||||
// figure out if plugins (and especially text input in things like
|
||||
// FabFilter plugins) work without this.
|
||||
// XXX: In theory we wouldn't have to do this for VST3 because
|
||||
// `IPlugView::onKey{Down,Up}` should handle all keyboard events. But
|
||||
// in practice a lot of hosts don't use that, so we still need to grab
|
||||
// focus ourselves.
|
||||
xcb_set_input_focus(x11_connection.get(), XCB_INPUT_FOCUS_PARENT,
|
||||
grab ? parent_window : topmost_window,
|
||||
XCB_CURRENT_TIME);
|
||||
|
||||
Reference in New Issue
Block a user