vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-17 06:00:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Prevent unnecessary copies in ScopedValueCache

Browse Source
This commit is contained in:
Robbert van der Helm
2021-05-01 16:16:25 +02:00
parent 7881e0116e
commit 167784f93b
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/utils.h
+6 -5
View File
@@ -144,19 +144,20 @@ class ScopedValueCache {
class Guard { class Guard {
public: public:
Guard(std::optional<T>& cached_value) : cached_value(cached_value) {} Guard(std::optional<T>& cached_value) : cached_value(cached_value) {}
~Guard() { ~Guard() {
if (is_active) { if (is_active) {
cached_value.reset(); cached_value.get().reset();
} }
} }
Guard(const Guard&) = delete; Guard(const Guard&) = delete;
Guard& operator=(const Guard&) = delete; Guard& operator=(const Guard&) = delete;
Guard(Guard&& o) : cached_value(o.cached_value) { o.is_active = false; } Guard(Guard&& o) : cached_value(std::move(o.cached_value)) {
o.is_active = false;
}
Guard& operator=(Guard&& o) { Guard& operator=(Guard&& o) {
cached_value = o.cache; cached_value = std::move(o.cached_value);
o.is_active = false; o.is_active = false;
return *this; return *this;
@@ -164,7 +165,7 @@ class ScopedValueCache {
private: private:
bool is_active = true; bool is_active = true;
std::optional<T>& cached_value; std::reference_wrapper<std::optional<T>> cached_value;
}; };
/** /**