vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-14 04:19:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Only set up VST3 SHM audio buffers in setActive()

Browse Source 
This avoids doing the duplicate check (since both `setProcessing()` and
`setActive()` would be called), and this also gets rid of the assumption
added a couple commits ago that `setupProcessing()` is only ever called
once, which is not true.
This commit is contained in:
Robbert van der Helm
2022-05-19 14:43:59 +02:00
parent 8c10edf861
commit 162aeed661
11 changed files with 21 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/logging/vst3.cpp
+2 -16
View File
@@ -1007,9 +1007,8 @@ bool Vst3Logger::log_request(
// TODO: The channel counts are now capped at what the plugin
// supports (based on the audio buffers we set up during
// `IAudioProcessor::setupProcessing()`). Some hosts may send
// more buffers, but we don't reflect that in the output right
// now.
// `IAudioProcessor::setActive()`). Some hosts may send more
// buffers, but we don't reflect that in the output right now.
std::ostringstream num_input_channels;
num_input_channels << "[";
for (bool is_first = true;
@@ -1788,19 +1787,6 @@ void Vst3Logger::log_response(
});
}
void Vst3Logger::log_response(
bool is_host_vst,
const YaAudioProcessor::SetupProcessingResponse& response) {
log_response_base(is_host_vst, [&](auto& message) {
message << response.result.string();
if (response.result == Steinberg::kResultOk) {
message << ", <shared memory configuration for \""
<< response.audio_buffers_config.name << "\", "
<< response.audio_buffers_config.size << " bytes>";
}
});
}
void Vst3Logger::log_response(
bool is_host_vst,
const YaAudioProcessor::ProcessResponse& response) {
src/common/logging/vst3.h
-2
View File
@@ -308,8 +308,6 @@ class Vst3Logger {
void log_response(bool is_host_vst,
const YaAudioProcessor::GetBusArrangementResponse&);
void log_response(bool is_host_vst,
const YaAudioProcessor::SetupProcessingResponse&);
void log_response(bool is_host_vst,
const YaAudioProcessor::ProcessResponse&);
void log_response(bool is_host_vst,