From 16203d7246eb352e9aed8975b5ed0df116ae0c59 Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Sun, 2 Jan 2022 20:24:03 +0100
Subject: [PATCH] Remove all remaining mentions of using symlinks

Since these should never be used anymore.
---
 .github/ISSUE_TEMPLATE/bug_report.yml | 11 -------
 .github/ISSUE_TEMPLATE/setup_help.yml | 11 -------
 tools/yabridgectl/README.md           | 45 ---------------------------
 3 files changed, 67 deletions(-)

diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
index b8a8039b..2e206074 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.yml
+++ b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -76,17 +76,6 @@ body:
       placeholder: e.g. Wine Staging 4.20, or wine-tkg 6.14
     validations:
       required: true
-  - type: dropdown
-    id: installation-method
-    attributes:
-      label: Plugin installation method
-      description: >-
-        From yabridge 2.1.0 onwards you should never have to use the old symlink
-        installation method anymore, and it will likely cause issues if you do
-        use it.
-      options: ["copies", "symlinks"]
-    validations:
-      required: true
   - type: input
     id: plugin
     attributes:
diff --git a/.github/ISSUE_TEMPLATE/setup_help.yml b/.github/ISSUE_TEMPLATE/setup_help.yml
index c3c59045..872cd8f2 100644
--- a/.github/ISSUE_TEMPLATE/setup_help.yml
+++ b/.github/ISSUE_TEMPLATE/setup_help.yml
@@ -65,17 +65,6 @@ body:
       placeholder: e.g. Wine Staging 4.20, or wine-tkg 6.14
     validations:
       required: true
-  - type: dropdown
-    id: installation-method
-    attributes:
-      label: Plugin installation method
-      description: >-
-        From yabridge 2.1.0 onwards you should never have to use the old symlink
-        installation method anymore, and it will likely cause issues if you do
-        use it.
-      options: ["copies", "symlinks"]
-    validations:
-      required: true
   - type: input
     id: plugin
     attributes:
diff --git a/tools/yabridgectl/README.md b/tools/yabridgectl/README.md
index fb7b386f..fd5ea459 100644
--- a/tools/yabridgectl/README.md
+++ b/tools/yabridgectl/README.md
@@ -29,19 +29,6 @@ directory instead.
 yabridgectl set --path=<path/to/directory/containing/yabridge/files>
 ```
 
-### Installation methods
-
-Yabridge can be set up using either copies or symlinks. By default, yabridgectl
-will use the copy-based installation method since this will work with any host,
-and there's usually no reason to use symlinks anymore. If you are using a DAW
-that supports individually sandboxed plugins such as Bitwig Studio, then you can
-choose between using copies and symlinks using the command below. Make sure to
-rerun `yabridgectl sync` after changing this setting.
-
-```shell
-yabridgectl set --method=<copy|symlink>
-```
-
 ### Managing directories
 
 Yabridgectl can manage multiple Windows plugin install locations for you.
@@ -88,38 +75,6 @@ yabridgectl sync --prune
 yabridgectl sync --force
 ```
 
-## Alternatives
-
-If you want to script your own installation behaviour and don't feel like using
-yabridgectl, then you could use one of the below bash snippets instead to set up
-yabridge for VST2 plugins. This approach is slightly less robust and does not
-perform any problem detection or status reporting, but it will get you started.
-Doing the same thing for VST3 plugins is much more complicated and it involves
-[merged
-bundle](https://developer.steinberg.help/display/VST/Plug-in+Format+Structure#PluginFormatStructure-MergedBundle)
-with the Windows VST3 module symlinked in, so it's recommended to have
-yabridgectl do that for you.
-
-```shell
-# For use with symlinks
-yabridge_home=$HOME/.local/share/yabridge
-plugin_dir="$HOME/.wine/drive_c/Program Files/Steinberg/VstPlugins"
-
-find -L "$plugin_dir" -type f -iname '*.dll' -print0 |
-  xargs -0 -P$(nproc) -I{} bash -c "(winedump -j export '{}' | grep -qE 'VSTPluginMain|main') && printf '{}\0'" |
-  sed -z 's/\.dll$/.so/' |
-  xargs -0 -n1 ln -sf "$yabridge_home/libyabridge.so"
-
-# For use with copies
-yabridge_home=$HOME/.local/share/yabridge
-plugin_dir="$HOME/.wine/drive_c/Program Files/Steinberg/VstPlugins"
-
-find -L "$plugin_dir" -type f -iname '*.dll' -print0 |
-  xargs -0 -P$(nproc) -I{} bash -c "(winedump -j export '{}' | grep -qE 'VSTPluginMain|main') && printf '{}\0'" |
-  sed -z 's/\.dll$/.so/' |
-  xargs -0 -n1 cp "$yabridge_home/libyabridge.so"
-```
-
 ## Building from source
 
 After installing [Rust](https://rustup.rs/), simply run the command below to