Only ignore -Wmaybe-uninitialized on GCC

An ifdef sounds like a better approach than ignoring two additional
warnings.
This commit is contained in:
Robbert van der Helm
2021-07-14 17:18:44 +02:00
parent f292158889
commit 0c816b0046
2 changed files with 6 additions and 6 deletions
@@ -27,9 +27,9 @@
// FIXME: When used in a Boost.Containers small vector, GCC somehow complains // FIXME: When used in a Boost.Containers small vector, GCC somehow complains
// that the fields in this class may be uninitialized (during the // that the fields in this class may be uninitialized (during the
// deserialization). This warning only shows up during a unity build. // deserialization). This warning only shows up during a unity build.
#pragma GCC diagnostic ignored "-Wpragmas" #if defined(__GNUC__) && !defined(__llvm__)
#pragma clang diagnostic ignored "-Wunknown-warning-option"
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif
/** /**
* Wraps around `IParamValueQueue` for serializing a queue containing changes to * Wraps around `IParamValueQueue` for serializing a queue containing changes to
+4 -4
View File
@@ -278,9 +278,9 @@ void WineXdndProxy::end_xdnd() {
// Oh and Clang doesn't know about -Wmaybe-uninitialized, so we need to // Oh and Clang doesn't know about -Wmaybe-uninitialized, so we need to
// ignore some more warnings here to get clangd to not complain // ignore some more warnings here to get clangd to not complain
#pragma GCC diagnostic push #pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpragmas" #if defined(__GNUC__) && !defined(__llvm__)
#pragma clang diagnostic ignored "-Wunknown-warning-option"
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif
void WineXdndProxy::run_xdnd_loop() { void WineXdndProxy::run_xdnd_loop() {
const HWND windows_desktop_window = GetDesktopWindow(); const HWND windows_desktop_window = GetDesktopWindow();
@@ -656,9 +656,9 @@ std::optional<xcb_window_t> WineXdndProxy::get_xdnd_proxy(
// FIXME: See above for more context, spurious warning is generated by passing // FIXME: See above for more context, spurious warning is generated by passing
// `*last_xdnd_window` to this function // `*last_xdnd_window` to this function
#pragma GCC diagnostic push #pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpragmas" #if defined(__GNUC__) && !defined(__llvm__)
#pragma clang diagnostic ignored "-Wunknown-warning-option"
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif
// NOLINTNEXTLINE(bugprone-easily-swappable-parameters) // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
void WineXdndProxy::send_xdnd_message(xcb_window_t window, void WineXdndProxy::send_xdnd_message(xcb_window_t window,