mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-09 20:29:10 +02:00
Reparent to the root window before deferring close
We did this before implementing the deferred close in yabridge 3.0.0. It didn't seem necessary anymore so we got rid of it, but without this closing an iZotope Rx plugin's editor in Renoise was guaranteed to trigger an X11 error and crash Renoise. Doing this reparent doesn't seem to cause any slowdown but it does at least fix the specific combination of iZotope Rx and Renoise.
This commit is contained in:
@@ -22,6 +22,14 @@ Versioning](https://semver.org/spec/v2.0.0.html).
|
||||
|
||||
### Fixed
|
||||
|
||||
- In certain rare circumstances, closing a plugin editor would trigger an X11
|
||||
error and crash the Wine plugin host, and with that likely the entire DAW.
|
||||
This happened because Wine would try to destroy a window that had already been
|
||||
destroyed. I've seen this happen in Renoise and to a lesser degree in REAPER
|
||||
with plugins that take a while to close their editors, such as the iZotope Rx
|
||||
plugins. We now explicitly reparent the window to back the root window first
|
||||
before deferring the window closing. This should work around the issue, while
|
||||
still keeping editor closing nice and snappy.
|
||||
- _PSPaudioware InifniStrip_ would fail to initialize because the plugin expects
|
||||
the host to always be using Microsoft COM and it won't initialize it by
|
||||
itself. InfiniStrip loads as expected now.
|
||||
|
||||
Reference in New Issue
Block a user