Change the naming scheme for class field members

I'm not a fan of Hungarian notation, but C++ kind of needs it with its
implicit `this`. And of all the common options for this, I find
suffixing members with an underscore the least offensive one.

src/common/serialization/vst3/plug-view/parameter-finder.cpp

@@ -24,4 +24,4 @@ YaParameterFinder::ConstructArgs::ConstructArgs(
           Steinberg::FUnknownPtr<Steinberg::Vst::IParameterFinder>(object)) {}
 
 YaParameterFinder::YaParameterFinder(ConstructArgs&& args) noexcept
-    : arguments(std::move(args)) {}
+    : arguments_(std::move(args)) {}

src/common/serialization/vst3/plug-view/parameter-finder.h

@@ -59,7 +59,7 @@ class YaParameterFinder : public Steinberg::Vst::IParameterFinder {
      */
     YaParameterFinder(ConstructArgs&& args) noexcept;
 
-    inline bool supported() const noexcept { return arguments.supported; }
+    inline bool supported() const noexcept { return arguments_.supported; }
 
     /**
      * The response code and editor size returned by a call to
@@ -102,7 +102,7 @@ class YaParameterFinder : public Steinberg::Vst::IParameterFinder {
                   Steinberg::Vst::ParamID& resultTag /*out*/) override = 0;
 
    protected:
-    ConstructArgs arguments;
+    ConstructArgs arguments_;
 };
 
 #pragma GCC diagnostic pop

src/common/serialization/vst3/plug-view/plug-view-content-scale-support.cpp

@@ -25,4 +25,4 @@ YaPlugViewContentScaleSupport::ConstructArgs::ConstructArgs(
 
 YaPlugViewContentScaleSupport::YaPlugViewContentScaleSupport(
     ConstructArgs&& args) noexcept
-    : arguments(std::move(args)) {}
+    : arguments_(std::move(args)) {}

src/common/serialization/vst3/plug-view/plug-view-content-scale-support.h

@@ -60,7 +60,7 @@ class YaPlugViewContentScaleSupport
      */
     YaPlugViewContentScaleSupport(ConstructArgs&& args) noexcept;
 
-    inline bool supported() const noexcept { return arguments.supported; }
+    inline bool supported() const noexcept { return arguments_.supported; }
 
     /**
      * Message to pass through a call to
@@ -85,7 +85,7 @@ class YaPlugViewContentScaleSupport
     setContentScaleFactor(ScaleFactor factor) override = 0;
 
    protected:
-    ConstructArgs arguments;
+    ConstructArgs arguments_;
 };
 
 #pragma GCC diagnostic pop

src/common/serialization/vst3/plug-view/plug-view.cpp

@@ -23,4 +23,4 @@ YaPlugView::ConstructArgs::ConstructArgs(
     : supported(Steinberg::FUnknownPtr<Steinberg::IPlugView>(object)) {}
 
 YaPlugView::YaPlugView(ConstructArgs&& args) noexcept
-    : arguments(std::move(args)) {}
+    : arguments_(std::move(args)) {}

src/common/serialization/vst3/plug-view/plug-view.h

@@ -61,7 +61,7 @@ class YaPlugView : public Steinberg::IPlugView {
      */
     YaPlugView(ConstructArgs&& args) noexcept;
 
-    inline bool supported() const noexcept { return arguments.supported; }
+    inline bool supported() const noexcept { return arguments_.supported; }
 
     /**
      * Message to pass through a call to
@@ -365,7 +365,7 @@ class YaPlugView : public Steinberg::IPlugView {
     checkSizeConstraint(Steinberg::ViewRect* rect) override = 0;
 
    protected:
-    ConstructArgs arguments;
+    ConstructArgs arguments_;
 };
 
 #pragma GCC diagnostic pop