mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-06-13 15:52:16 +02:00
Change the naming scheme for class field members
I'm not a fan of Hungarian notation, but C++ kind of needs it with its implicit `this`. And of all the common options for this, I find suffixing members with an underscore the least offensive one.
This commit is contained in:
@@ -24,4 +24,4 @@ YaComponentHandler2::ConstructArgs::ConstructArgs(
|
||||
Steinberg::FUnknownPtr<Steinberg::Vst::IComponentHandler2>(object)) {}
|
||||
|
||||
YaComponentHandler2::YaComponentHandler2(ConstructArgs&& args) noexcept
|
||||
: arguments(std::move(args)) {}
|
||||
: arguments_(std::move(args)) {}
|
||||
|
||||
@@ -59,7 +59,7 @@ class YaComponentHandler2 : public Steinberg::Vst::IComponentHandler2 {
|
||||
*/
|
||||
YaComponentHandler2(ConstructArgs&& args) noexcept;
|
||||
|
||||
inline bool supported() const noexcept { return arguments.supported; }
|
||||
inline bool supported() const noexcept { return arguments_.supported; }
|
||||
|
||||
/**
|
||||
* Message to pass through a call to `IComponentHandler2::setDirty(state)`
|
||||
@@ -138,7 +138,7 @@ class YaComponentHandler2 : public Steinberg::Vst::IComponentHandler2 {
|
||||
virtual tresult PLUGIN_API finishGroupEdit() override = 0;
|
||||
|
||||
protected:
|
||||
ConstructArgs arguments;
|
||||
ConstructArgs arguments_;
|
||||
};
|
||||
|
||||
#pragma GCC diagnostic pop
|
||||
|
||||
@@ -24,4 +24,4 @@ YaComponentHandler3::ConstructArgs::ConstructArgs(
|
||||
Steinberg::FUnknownPtr<Steinberg::Vst::IComponentHandler3>(object)) {}
|
||||
|
||||
YaComponentHandler3::YaComponentHandler3(ConstructArgs&& args) noexcept
|
||||
: arguments(std::move(args)) {}
|
||||
: arguments_(std::move(args)) {}
|
||||
|
||||
@@ -61,7 +61,7 @@ class YaComponentHandler3 : public Steinberg::Vst::IComponentHandler3 {
|
||||
*/
|
||||
YaComponentHandler3(ConstructArgs&& args) noexcept;
|
||||
|
||||
inline bool supported() const noexcept { return arguments.supported; }
|
||||
inline bool supported() const noexcept { return arguments_.supported; }
|
||||
|
||||
/**
|
||||
* The arguments needed to create a proxy object for the context menu
|
||||
@@ -110,7 +110,7 @@ class YaComponentHandler3 : public Steinberg::Vst::IComponentHandler3 {
|
||||
const Steinberg::Vst::ParamID* paramID) override = 0;
|
||||
|
||||
protected:
|
||||
ConstructArgs arguments;
|
||||
ConstructArgs arguments_;
|
||||
};
|
||||
|
||||
#pragma GCC diagnostic pop
|
||||
|
||||
+1
-1
@@ -25,4 +25,4 @@ YaComponentHandlerBusActivation::ConstructArgs::ConstructArgs(
|
||||
|
||||
YaComponentHandlerBusActivation::YaComponentHandlerBusActivation(
|
||||
ConstructArgs&& args) noexcept
|
||||
: arguments(std::move(args)) {}
|
||||
: arguments_(std::move(args)) {}
|
||||
|
||||
@@ -62,7 +62,7 @@ class YaComponentHandlerBusActivation
|
||||
*/
|
||||
YaComponentHandlerBusActivation(ConstructArgs&& args) noexcept;
|
||||
|
||||
inline bool supported() const noexcept { return arguments.supported; }
|
||||
inline bool supported() const noexcept { return arguments_.supported; }
|
||||
|
||||
/**
|
||||
* Message to pass through a call to
|
||||
@@ -96,7 +96,7 @@ class YaComponentHandlerBusActivation
|
||||
TBool state) override = 0;
|
||||
|
||||
protected:
|
||||
ConstructArgs arguments;
|
||||
ConstructArgs arguments_;
|
||||
};
|
||||
|
||||
#pragma GCC diagnostic pop
|
||||
|
||||
@@ -23,4 +23,4 @@ YaProgress::ConstructArgs::ConstructArgs(
|
||||
: supported(Steinberg::FUnknownPtr<Steinberg::Vst::IProgress>(object)) {}
|
||||
|
||||
YaProgress::YaProgress(ConstructArgs&& args) noexcept
|
||||
: arguments(std::move(args)) {}
|
||||
: arguments_(std::move(args)) {}
|
||||
|
||||
@@ -60,7 +60,7 @@ class YaProgress : public Steinberg::Vst::IProgress {
|
||||
*/
|
||||
YaProgress(ConstructArgs&& args) noexcept;
|
||||
|
||||
inline bool supported() const noexcept { return arguments.supported; }
|
||||
inline bool supported() const noexcept { return arguments_.supported; }
|
||||
|
||||
/**
|
||||
* The response code and returned ID for a call to `IProgress::start(type,
|
||||
@@ -154,7 +154,7 @@ class YaProgress : public Steinberg::Vst::IProgress {
|
||||
virtual tresult PLUGIN_API finish(ID id) override = 0;
|
||||
|
||||
protected:
|
||||
ConstructArgs arguments;
|
||||
ConstructArgs arguments_;
|
||||
};
|
||||
|
||||
#pragma GCC diagnostic pop
|
||||
|
||||
@@ -24,4 +24,4 @@ YaUnitHandler2::ConstructArgs::ConstructArgs(
|
||||
}
|
||||
|
||||
YaUnitHandler2::YaUnitHandler2(ConstructArgs&& args) noexcept
|
||||
: arguments(std::move(args)) {}
|
||||
: arguments_(std::move(args)) {}
|
||||
|
||||
@@ -59,7 +59,7 @@ class YaUnitHandler2 : public Steinberg::Vst::IUnitHandler2 {
|
||||
*/
|
||||
YaUnitHandler2(ConstructArgs&& args) noexcept;
|
||||
|
||||
inline bool supported() const noexcept { return arguments.supported; }
|
||||
inline bool supported() const noexcept { return arguments_.supported; }
|
||||
|
||||
/**
|
||||
* Message to pass through a call to
|
||||
@@ -80,7 +80,7 @@ class YaUnitHandler2 : public Steinberg::Vst::IUnitHandler2 {
|
||||
virtual tresult PLUGIN_API notifyUnitByBusChange() override = 0;
|
||||
|
||||
protected:
|
||||
ConstructArgs arguments;
|
||||
ConstructArgs arguments_;
|
||||
};
|
||||
|
||||
#pragma GCC diagnostic pop
|
||||
|
||||
@@ -23,4 +23,4 @@ YaUnitHandler::ConstructArgs::ConstructArgs(
|
||||
: supported(Steinberg::FUnknownPtr<Steinberg::Vst::IUnitHandler>(object)) {}
|
||||
|
||||
YaUnitHandler::YaUnitHandler(ConstructArgs&& args) noexcept
|
||||
: arguments(std::move(args)) {}
|
||||
: arguments_(std::move(args)) {}
|
||||
|
||||
@@ -59,7 +59,7 @@ class YaUnitHandler : public Steinberg::Vst::IUnitHandler {
|
||||
*/
|
||||
YaUnitHandler(ConstructArgs&& args) noexcept;
|
||||
|
||||
inline bool supported() const noexcept { return arguments.supported; }
|
||||
inline bool supported() const noexcept { return arguments_.supported; }
|
||||
|
||||
/**
|
||||
* Message to pass through a call to
|
||||
@@ -109,7 +109,7 @@ class YaUnitHandler : public Steinberg::Vst::IUnitHandler {
|
||||
int32 programIndex) override = 0;
|
||||
|
||||
protected:
|
||||
ConstructArgs arguments;
|
||||
ConstructArgs arguments_;
|
||||
};
|
||||
|
||||
#pragma GCC diagnostic pop
|
||||
|
||||
Reference in New Issue
Block a user