vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-15 04:50:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Remove cache_time_info and always cache time info"

Browse Source 
This reverts commit cfb171c991.

No idea why, but this cache breaks SPL Transient Designer Plus. Perhaps
it overwrites the time info?
This commit is contained in:
Robbert van der Helm
2021-01-30 02:37:27 +01:00
parent 9858db25d2
commit 0adca3e33c
7 changed files with 44 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst2.cpp
+10 -7
View File
@@ -178,7 +178,9 @@ Vst2Bridge::Vst2Bridge(MainContext& main_context,
// value returned by this function during an audio
// processing cycle will be reused for the rest of the
// cycle.
cached_time_info.reset();
if (config.cache_time_info) {
time_info.reset();
}
// Since the host should only be calling one of `process()`,
// processReplacing()` or `processDoubleReplacing()`, we can all
@@ -546,14 +548,15 @@ intptr_t Vst2Bridge::host_callback(AEffect* effect,
void* data,
float option) {
// HACK: Workaround for a bug in SWAM Cello where it would call
// `audioMasterGetTime()` once for every sample. The `time_info` value
// is assigned inside of `HostCallbackDataConverter::write()`. At the
// beginning of the processing cycle this value will be reset.
if (cached_time_info) {
return reinterpret_cast<intptr_t>(&*cached_time_info);
// `audioMasterGetTime()` once for every sample. When this option is
// enabled `time_info` should be reset in the process function. The
// `time_info` value is assigned inside of
// `HostCallbackDataConverter::write()`.
if (config.cache_time_info && time_info) {
return reinterpret_cast<intptr_t>(&*time_info);
}
HostCallbackDataConverter converter(effect, cached_time_info);
HostCallbackDataConverter converter(effect, time_info);
return sockets.vst_host_callback.send_event(converter, std::nullopt, opcode,
index, value, data, option);
}