From 0617bfb5653f139778dd66a229c684350afc1df7 Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Thu, 7 Jan 2021 14:47:00 +0100
Subject: [PATCH] Add logging for IContextMenu

---
 src/common/logging/vst3.cpp | 42 +++++++++++++++++++++++++++++++++++--
 src/common/logging/vst3.h   |  4 ++++
 2 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/src/common/logging/vst3.cpp b/src/common/logging/vst3.cpp
index 703b06da..48297429 100644
--- a/src/common/logging/vst3.cpp
+++ b/src/common/logging/vst3.cpp
@@ -937,8 +937,6 @@ bool Vst3Logger::log_request(bool is_host_vst,
 bool Vst3Logger::log_request(bool is_host_vst,
                              const Vst3ContextMenuProxy::Destruct& request) {
     return log_request_base(is_host_vst, [&](auto& message) {
-        // We don't know what class this instance was originally instantiated
-        // as, but it also doesn't really matter
         message << request.owner_instance_id << ": <IContextMenu* #"
                 << request.context_menu_id << ">::~IContextMenu()";
     });
@@ -1035,6 +1033,46 @@ bool Vst3Logger::log_request(
     });
 }
 
+bool Vst3Logger::log_request(bool is_host_vst,
+                             const YaContextMenu::GetItemCount& request) {
+    return log_request_base(is_host_vst, [&](auto& message) {
+        message << request.owner_instance_id << ": <IContextMenu* #"
+                << request.context_menu_id << ">::getItemCount()";
+    });
+}
+
+bool Vst3Logger::log_request(bool is_host_vst,
+                             const YaContextMenu::AddItem& request) {
+    return log_request_base(is_host_vst, [&](auto& message) {
+        message << request.owner_instance_id << ": <IContextMenu* #"
+                << request.context_menu_id
+                << ">::addItem(item = <IContextMenuItem #" << request.item.tag
+                << " for \"" << VST3::StringConvert::convert(request.item.name)
+                << "\">, target)";
+    });
+}
+
+bool Vst3Logger::log_request(bool is_host_vst,
+                             const YaContextMenu::RemoveItem& request) {
+    return log_request_base(is_host_vst, [&](auto& message) {
+        message << request.owner_instance_id << ": <IContextMenu* #"
+                << request.context_menu_id
+                << ">::removeItem(item = <IContextMenuItem #"
+                << request.item.tag << " for \""
+                << VST3::StringConvert::convert(request.item.name)
+                << "\">, target)";
+    });
+}
+
+bool Vst3Logger::log_request(bool is_host_vst,
+                             const YaContextMenu::Popup& request) {
+    return log_request_base(is_host_vst, [&](auto& message) {
+        message << request.owner_instance_id << ": <IContextMenu* #"
+                << request.context_menu_id << ">::popup(x = " << request.x
+                << ", y = " << request.y << ")";
+    });
+}
+
 bool Vst3Logger::log_request(bool is_host_vst,
                              const YaHostApplication::GetName& request) {
     return log_request_base(is_host_vst, [&](auto& message) {
diff --git a/src/common/logging/vst3.h b/src/common/logging/vst3.h
index ac22b3ab..76dff2f5 100644
--- a/src/common/logging/vst3.h
+++ b/src/common/logging/vst3.h
@@ -188,6 +188,10 @@ class Vst3Logger {
                      const YaComponentHandler2::FinishGroupEdit&);
     bool log_request(bool is_host_vst,
                      const YaComponentHandler3::CreateContextMenu&);
+    bool log_request(bool is_host_vst, const YaContextMenu::GetItemCount&);
+    bool log_request(bool is_host_vst, const YaContextMenu::AddItem&);
+    bool log_request(bool is_host_vst, const YaContextMenu::RemoveItem&);
+    bool log_request(bool is_host_vst, const YaContextMenu::Popup&);
     bool log_request(bool is_host_vst, const YaHostApplication::GetName&);
     bool log_request(bool is_host_vst, const YaPlugFrame::ResizeView&);
     bool log_request(bool is_host_vst,