vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-08 04:20:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Allow passing null pointers to IPlugView::setFrame

Browse Source
This commit is contained in:
Robbert van der Helm
2021-01-24 14:44:42 +01:00
parent d5e4424463
commit 0044bc6b60
4 changed files with 35 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin/bridges/vst3-impls/plug-view-proxy.cpp
+8 -4
View File
@@ -200,7 +200,8 @@ tresult PLUGIN_API Vst3PlugViewProxyImpl::onFocus(TBool state) {
tresult PLUGIN_API
Vst3PlugViewProxyImpl::setFrame(Steinberg::IPlugFrame* frame) {
// TODO: Null pointers are valid here, should we pass them through?
// Null pointers are valid here going from the reference implementations in
// the SDK
if (frame) {
// We'll store the pointer for when the plugin later makes a callback to
// this component handler
@@ -229,9 +230,12 @@ Vst3PlugViewProxyImpl::setFrame(Steinberg::IPlugFrame* frame) {
.plug_frame_args = Vst3PlugFrameProxy::ConstructArgs(
plug_frame, owner_instance_id())});
} else {
bridge.logger.log(
"WARNING: Null pointer passed to 'IPlugView::setFrame()'");
return Steinberg::kInvalidArgument;
plug_frame.reset();
run_loop_tasks.reset();
return send_mutually_recursive_message(
YaPlugView::SetFrame{.owner_instance_id = owner_instance_id(),
.plug_frame_args = std::nullopt});
}
}