From 273aa846d54957f2e1ba943af9b598eb91bfcb97 Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Thu, 13 Apr 2023 11:23:33 -0700 Subject: [PATCH 1/4] Less pedantic compile warnings --- src/CMakeLists.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index e956264..e1d0788 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -45,9 +45,7 @@ if (MSVC) ) else() target_compile_options(neural_amp_modeler PRIVATE - -Wall -Wextra -Wpedantic -Wshadow -Wstrict-aliasing - -Wunreachable-code -Wdouble-promotion -Weffc++ -Wconversion - -Wsign-conversion + -Wall -Wextra -Wpedantic -Wstrict-aliasing -Wunreachable-code -Weffc++ -Wno-unused-parameter "$<$:-Og;-ggdb;-Werror>" "$<$:-Ofast>" ) From e7ba7a54bd1fd8773fc994ce1263131d6a526ad9 Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Thu, 13 Apr 2023 11:38:36 -0700 Subject: [PATCH 2/4] Sync NeuralAmpModelerCore --- deps/NeuralAmpModelerCore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/NeuralAmpModelerCore b/deps/NeuralAmpModelerCore index aa777b5..45d0c4f 160000 --- a/deps/NeuralAmpModelerCore +++ b/deps/NeuralAmpModelerCore @@ -1 +1 @@ -Subproject commit aa777b5f14548178982bdc1b6eb09c6137fdb134 +Subproject commit 45d0c4f6a40693f85546da1d14fe2eec44351019 From 6ad5b29c96ecc9aea58667d0cc8d5294b227b7f7 Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Thu, 13 Apr 2023 11:45:44 -0700 Subject: [PATCH 3/4] Update NeuralAmpModelerCore --- deps/NeuralAmpModelerCore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/NeuralAmpModelerCore b/deps/NeuralAmpModelerCore index 45d0c4f..1481c71 160000 --- a/deps/NeuralAmpModelerCore +++ b/deps/NeuralAmpModelerCore @@ -1 +1 @@ -Subproject commit 45d0c4f6a40693f85546da1d14fe2eec44351019 +Subproject commit 1481c71a209cf35d1e99bc788defad7379bd6546 From 1bf2b3031537c21000541da06902bfeaa0b28b8a Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Sun, 16 Apr 2023 13:18:52 -0700 Subject: [PATCH 4/4] run build on pr --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4d36030..2bb49d3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,7 +1,7 @@ name: Build on: - workflow_dispatch + [workflow_dispatch, pull_request] env: BUILD_TYPE: Release