From 09166f198ba0be68622f06e5c2adccc0633f29b4 Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Mon, 4 Nov 2024 07:37:52 -0800 Subject: [PATCH 1/6] Update CREDITS.md --- CREDITS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CREDITS.md b/CREDITS.md index 46ebc2e..e8eec39 100644 --- a/CREDITS.md +++ b/CREDITS.md @@ -4,6 +4,8 @@ https://github.com/sdatkinson/NeuralAmpModelerCore https://gitlab.com/libeigen/eigen +https://github.com/jatinchowdhury18/RTNeural + https://github.com/lv2/lv2 In addition, the CMake structure and LV2 plugin structure are based on code from https://github.com/Dougal-s/Aether. From 94a48c2862f2ba54960c0283c4739e569ffd2aae Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Mon, 4 Nov 2024 07:50:26 -0800 Subject: [PATCH 2/6] Create release.yml --- .github/workflows/release.yml | 57 +++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 .github/workflows/release.yml diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml new file mode 100644 index 0000000..d537e2a --- /dev/null +++ b/.github/workflows/release.yml @@ -0,0 +1,57 @@ +name: Release + +on: + workflow_dispatch: + +env: + BUILD_TYPE: Release + +jobs: + create_release: + name: Create release + runs-on: ubuntu-latest + outputs: + upload_url: ${{steps.create_release.outputs.upload_url}} + steps: + - name: Check out repository + uses: actions/checkout@v4 + with: + submodules: recursive + + - name: Create release + id: create_release + uses: actions/create-release@v1 + env: + GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + with: + draft: true + tag_name: ${{github.ref}} + release_name: Release ${{github.ref}} + + build-windows: + name: Build Windows + needs: create_release + runs-on: windows-latest + steps: + - uses: actions/checkout@v3.3.0 + with: + submodules: recursive + + - name: Build Plugin + working-directory: ${{github.workspace}}/build + run: | + cmake.exe -G "Visual Studio 17 2022" -A x64 -T ClangCL .. + cmake --build . --config=release -j4 + + - name: Add LV2 Archive + run: Compress-Archive -Path ${{github.workspace}}\build\neural_amp_modeler.lv2 -Destination neural_amp_modeler.lv2.zip + + - name: Upload Plugin Asset + uses: actions/upload-release-asset@v1 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + with: + upload_url: ${{ needs.create_release.outputs.upload_url }} + asset_path: ./neural_amp_modeler.lv2.zip + asset_name: neural_amp_modeler.lv2.zip + asset_content_type: application/zip From 5b2c9a154f3ad46bfe8bf66c016276fdd6ee526b Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Mon, 4 Nov 2024 08:09:45 -0800 Subject: [PATCH 3/6] Update README.md --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9477a04..0c9b395 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # neural-amp-modeler-lv2 -Bare-bones implementation of [Neural Amp Modeler](https://github.com/sdatkinson/neural-amp-modeler) (NAM) models in an LV2 plugin. +LV2 plugin for using neural network machine learning amp models. **There is no user interface**. Setting the model to use requires that your LV2 host supports atom:Path parameters. Reaper does as of v6.82. Carla and Ardour do. If your favorite LV2 host does not support atom:Path, let them know you want it. If you are looking for a GUI version, @brummer10 [has one here](https://github.com/brummer10/neural-amp-modeler-ui) that works for Linux and Windows. You may also be interested in the the version shipped with the [MOD Desktop App](https://github.com/moddevices/mod-desktop-app), or my digital pedalboard app [Stompbox](https://github.com/mikeoliphant/StompboxUI). @@ -11,9 +11,11 @@ For amp-only models (the most typical), **you will need to run an impulse repons ### Models and Performance +The plugin supports both [Neural Amp Modeler (NAM)](https://github.com/sdatkinson/neural-amp-modeler) models and [RTNeural keras json models](https://github.com/jatinchowdhury18/RTNeural) (like those used by [Aida-X](https://github.com/AidaDSP/AIDA-X)). + The best source of models is [ToneHunt](https://tonehunt.org/). -NAM models are generally quite expensive to run. This isn't (much of) an issue on modern PCs, but you may have trouble running on less powerful hardware. +NAM WaveNet models are generally quite expensive to run. This isn't (much of) an issue on modern PCs, but you may have trouble running on less powerful hardware. A Raspberry Pi 4 running a 64bit OS can run "standard" NAM models with a bit of room to spare for a cabinet IR and some lightweight effects. From 75fcc78baef71ba41c57e51e6d18b02253aaf9ba Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Mon, 4 Nov 2024 08:10:07 -0800 Subject: [PATCH 4/6] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0c9b395..41efebc 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ LV2 plugin for using neural network machine learning amp models. -**There is no user interface**. Setting the model to use requires that your LV2 host supports atom:Path parameters. Reaper does as of v6.82. Carla and Ardour do. If your favorite LV2 host does not support atom:Path, let them know you want it. +**There is no custom plugin user interface**. Setting the model to use requires that your LV2 host supports atom:Path parameters. Reaper does as of v6.82. Carla and Ardour do. If your favorite LV2 host does not support atom:Path, let them know you want it. If you are looking for a GUI version, @brummer10 [has one here](https://github.com/brummer10/neural-amp-modeler-ui) that works for Linux and Windows. You may also be interested in the the version shipped with the [MOD Desktop App](https://github.com/moddevices/mod-desktop-app), or my digital pedalboard app [Stompbox](https://github.com/mikeoliphant/StompboxUI). To get the intended behavior, **you must run your audio host at the same sample rate the model was trained at** (usually 48kHz) - no resampling is done by the plugin. From 84f5851b5d24b3b82dda7a05756e927e0b20fe68 Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Mon, 4 Nov 2024 08:10:54 -0800 Subject: [PATCH 5/6] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 41efebc..ea55886 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ NAM WaveNet models are generally quite expensive to run. This isn't (much of) an A Raspberry Pi 4 running a 64bit OS can run "standard" NAM models with a bit of room to spare for a cabinet IR and some lightweight effects. -If you are having trouble running a "standard" model, try looking for "feather" (the least expensive) models. You can find a list of ["feather"-tagged models on ToneHunt](https://tonehunt.org/?tags=feather-mdl). Note that tagging models is up to the submitter, so not all "feather" models are tagged as such - you should be able to find more if you dig around. +If you are having trouble running a "standard" model, try looking for "feather", or even "nano" (the least expensive) models. You can find a list of ["feather"-tagged models on ToneHunt](https://tonehunt.org/?tags=feather-mdl). Note that tagging models is up to the submitter, so not all "feather" models are tagged as such - you should be able to find more if you dig around. ### Building From 69bfdb4370f80d8556709665e0009d57ba428f4e Mon Sep 17 00:00:00 2001 From: Mike Oliphant Date: Mon, 4 Nov 2024 08:12:04 -0800 Subject: [PATCH 6/6] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ea55886..678b22c 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ NAM WaveNet models are generally quite expensive to run. This isn't (much of) an A Raspberry Pi 4 running a 64bit OS can run "standard" NAM models with a bit of room to spare for a cabinet IR and some lightweight effects. -If you are having trouble running a "standard" model, try looking for "feather", or even "nano" (the least expensive) models. You can find a list of ["feather"-tagged models on ToneHunt](https://tonehunt.org/?tags=feather-mdl). Note that tagging models is up to the submitter, so not all "feather" models are tagged as such - you should be able to find more if you dig around. +If you are having trouble running a "standard" model, try looking for "feather", or even "nano" (the least expensive) models. You can find a list of ["feather"-tagged models on ToneHunt](https://tonehunt.org/models?tags%5B0%5D=feather-mdl). Note that tagging models is up to the submitter, so not all "feather" models are tagged as such - you should be able to find more if you dig around. ### Building