Files
gluetun/internal/natpmp/checks_test.go
T
Quentin McGaw 4a78989d9d chore: do not use sentinel errors when unneeded
- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
2026-05-02 03:29:46 +00:00

163 lines
3.9 KiB
Go

package natpmp
import (
"errors"
"testing"
"github.com/stretchr/testify/assert"
)
func Test_checkRequest(t *testing.T) {
t.Parallel()
testCases := map[string]struct {
request []byte
errMessage string
}{
"too_short": {
request: []byte{1},
errMessage: "message size is too small: need at least 2 bytes and got 1 byte(s)",
},
"success": {
request: []byte{0, 0},
},
}
for name, testCase := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := checkRequest(testCase.request)
if testCase.errMessage != "" {
assert.EqualError(t, err, testCase.errMessage)
} else {
assert.NoError(t, err)
}
})
}
}
func Test_checkResponse(t *testing.T) {
t.Parallel()
testCases := map[string]struct {
response []byte
expectedOperationCode byte
expectedResponseSize uint
err error
errMessage string
}{
"too_short": {
response: []byte{1},
err: errors.New("response size is too small"),
errMessage: "response size is too small: need at least 4 bytes and got 1 byte(s)",
},
"size_mismatch": {
response: []byte{0, 0, 0, 0},
expectedResponseSize: 5,
err: errors.New("response size is unexpected"),
errMessage: "response size is unexpected: expected 5 bytes and got 4 byte(s)",
},
"protocol_unknown": {
response: []byte{1, 0, 0, 0},
expectedResponseSize: 4,
err: errors.New("protocol version is unknown"),
errMessage: "protocol version is unknown: 1",
},
"operation_code_unexpected": {
response: []byte{0, 2, 0, 0},
expectedOperationCode: 1,
expectedResponseSize: 4,
err: errors.New("operation code is unexpected"),
errMessage: "operation code is unexpected: expected 0x1 and got 0x2",
},
"result_code_failure": {
response: []byte{0, 1, 0, 1},
expectedOperationCode: 1,
expectedResponseSize: 4,
err: errors.New("version is not supported"),
errMessage: "result code: version is not supported",
},
"success": {
response: []byte{0, 1, 0, 0},
expectedOperationCode: 1,
expectedResponseSize: 4,
},
}
for name, testCase := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := checkResponse(testCase.response,
testCase.expectedOperationCode,
testCase.expectedResponseSize)
if testCase.err != nil {
assert.ErrorContains(t, err, testCase.err.Error())
assert.EqualError(t, err, testCase.errMessage)
} else {
assert.NoError(t, err)
}
})
}
}
func Test_checkResultCode(t *testing.T) {
t.Parallel()
testCases := map[string]struct {
resultCode uint16
err error
errMessage string
}{
"success": {},
"version_unsupported": {
resultCode: 1,
err: errors.New("version is not supported"),
errMessage: "version is not supported",
},
"not_authorized": {
resultCode: 2,
err: errors.New("not authorized"),
errMessage: "not authorized",
},
"network_failure": {
resultCode: 3,
err: errors.New("network failure"),
errMessage: "network failure",
},
"out_of_resources": {
resultCode: 4,
err: errors.New("out of resources"),
errMessage: "out of resources",
},
"unsupported_operation_code": {
resultCode: 5,
err: errors.New("operation code is not supported"),
errMessage: "operation code is not supported",
},
"unknown": {
resultCode: 6,
err: errors.New("result code is unknown"),
errMessage: "result code is unknown: 6",
},
}
for name, testCase := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := checkResultCode(testCase.resultCode)
if testCase.err != nil {
assert.ErrorContains(t, err, testCase.err.Error())
assert.EqualError(t, err, testCase.errMessage)
} else {
assert.NoError(t, err)
}
})
}
}