mirror of
https://github.com/qdm12/gluetun.git
synced 2026-05-06 20:10:11 +02:00
Quentin McGaw
4a78989d9d
- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly - only use sentinel errors when it has to be checked using `errors.Is` - replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error - exclude the sentinel error definition requirement from .golangci.yml - update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
106 lines
2.6 KiB
Go
106 lines
2.6 KiB
Go
package command
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_split(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
testCases := map[string]struct {
|
|
command string
|
|
words []string
|
|
errMessage string
|
|
}{
|
|
"empty": {
|
|
command: "",
|
|
errMessage: "command is empty",
|
|
},
|
|
"concrete_sh_command": {
|
|
command: `/bin/sh -c "echo 123"`,
|
|
words: []string{"/bin/sh", "-c", "echo 123"},
|
|
},
|
|
"single_word": {
|
|
command: "word1",
|
|
words: []string{"word1"},
|
|
},
|
|
"two_words_single_space": {
|
|
command: "word1 word2",
|
|
words: []string{"word1", "word2"},
|
|
},
|
|
"two_words_multiple_space": {
|
|
command: "word1 word2",
|
|
words: []string{"word1", "word2"},
|
|
},
|
|
"two_words_no_expansion": {
|
|
command: "word1* word2?",
|
|
words: []string{"word1*", "word2?"},
|
|
},
|
|
"escaped_single quote": {
|
|
command: "ain\\'t good",
|
|
words: []string{"ain't", "good"},
|
|
},
|
|
"escaped_single_quote_all_single_quoted": {
|
|
command: "'ain'\\''t good'",
|
|
words: []string{"ain't good"},
|
|
},
|
|
"empty_single_quoted": {
|
|
command: "word1 '' word2",
|
|
words: []string{"word1", "", "word2"},
|
|
},
|
|
"escaped_newline": {
|
|
command: "word1\\\nword2",
|
|
words: []string{"word1word2"},
|
|
},
|
|
"quoted_newline": {
|
|
command: "text \"with\na\" quoted newline",
|
|
words: []string{"text", "with\na", "quoted", "newline"},
|
|
},
|
|
"quoted_escaped_newline": {
|
|
command: "\"word1\\d\\\\\\\" word2\\\nword3 word4\"",
|
|
words: []string{"word1\\d\\\" word2word3 word4"},
|
|
},
|
|
"escaped_separated_newline": {
|
|
command: "word1 \\\n word2",
|
|
words: []string{"word1", "word2"},
|
|
},
|
|
"double_quotes_no_spacing": {
|
|
command: "word1\"word2\"word3",
|
|
words: []string{"word1word2word3"},
|
|
},
|
|
"unterminated_single_quote": {
|
|
command: "'abc'\\''def",
|
|
errMessage: `splitting word in "'abc'\\''def": unterminated single-quoted string`,
|
|
},
|
|
"unterminated_double_quote": {
|
|
command: "\"abc'def",
|
|
errMessage: `splitting word in "\"abc'def": unterminated double-quoted string`,
|
|
},
|
|
"unterminated_escape": {
|
|
command: "abc\\",
|
|
errMessage: `splitting word in "abc\\": unterminated backslash-escape`,
|
|
},
|
|
"unterminated_escape_only": {
|
|
command: " \\",
|
|
errMessage: `unterminated backslash-escape: " \\"`,
|
|
},
|
|
}
|
|
|
|
for name, testCase := range testCases {
|
|
t.Run(name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
words, err := split(testCase.command)
|
|
|
|
assert.Equal(t, testCase.words, words)
|
|
if testCase.errMessage != "" {
|
|
assert.ErrorContains(t, err, testCase.errMessage)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|