From efea16949554a47f8fd88ec3149d83c66a28e138 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Wed, 11 Mar 2026 16:26:13 +0000 Subject: [PATCH] hotfix(vpn): fix vpn stop when down command is empty --- internal/vpn/cleanup.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/internal/vpn/cleanup.go b/internal/vpn/cleanup.go index 5c768757..fbc58f0d 100644 --- a/internal/vpn/cleanup.go +++ b/internal/vpn/cleanup.go @@ -13,10 +13,12 @@ func (l *Loop) cleanup() { settings := l.GetSettings() var err error - commandString := strings.ReplaceAll(*settings.DownCommand, "{{VPN_INTERFACE}}", getVPNInterface(settings)) - err = l.cmder.RunAndLog(context.Background(), commandString, l.logger) - if err != nil { - l.logger.Error("failed to run VPN down command: " + err.Error()) + if *settings.DownCommand != "" { + commandString := strings.ReplaceAll(*settings.DownCommand, "{{VPN_INTERFACE}}", getVPNInterface(settings)) + err = l.cmder.RunAndLog(context.Background(), commandString, l.logger) + if err != nil { + l.logger.Error("failed to run VPN down command: " + err.Error()) + } } for _, vpnPort := range l.vpnInputPorts {