From b11de4f0c3917d12fe88183fb137a21e23859fd6 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Sun, 19 Apr 2026 17:51:20 +0000 Subject: [PATCH] fix(privateinternetaccess): remove none encryption preset --- internal/configuration/settings/openvpnselection.go | 1 - internal/provider/privateinternetaccess/connection.go | 2 +- internal/provider/privateinternetaccess/openvpnconf.go | 4 ---- internal/provider/privateinternetaccess/presets/presets.go | 1 - 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/internal/configuration/settings/openvpnselection.go b/internal/configuration/settings/openvpnselection.go index cc858ad0..c72f62d2 100644 --- a/internal/configuration/settings/openvpnselection.go +++ b/internal/configuration/settings/openvpnselection.go @@ -132,7 +132,6 @@ func (o OpenVPNSelection) validate(vpnProvider string) (err error) { // Validate EncPreset if vpnProvider == providers.PrivateInternetAccess { validEncryptionPresets := []string{ - presets.None, presets.Normal, presets.Strong, } diff --git a/internal/provider/privateinternetaccess/connection.go b/internal/provider/privateinternetaccess/connection.go index 5ff07ecc..652da1f0 100644 --- a/internal/provider/privateinternetaccess/connection.go +++ b/internal/provider/privateinternetaccess/connection.go @@ -13,7 +13,7 @@ func (p *Provider) GetConnection(selection settings.ServerSelection, ipv6Support // Set port defaults depending on encryption preset. var defaults utils.ConnectionDefaults switch *selection.OpenVPN.PIAEncPreset { - case presets.None, presets.Normal: + case presets.Normal: defaults.OpenVPNTCPPort = 502 defaults.OpenVPNUDPPort = 1198 case presets.Strong: diff --git a/internal/provider/privateinternetaccess/openvpnconf.go b/internal/provider/privateinternetaccess/openvpnconf.go index 3bc5e754..b1938515 100644 --- a/internal/provider/privateinternetaccess/openvpnconf.go +++ b/internal/provider/privateinternetaccess/openvpnconf.go @@ -27,10 +27,6 @@ func (p *Provider) OpenVPNConfig(connection models.Connection, providerSettings.Ciphers = []string{openvpn.AES128cbc} providerSettings.Auth = openvpn.SHA1 providerSettings.CAs = []string{caNormalPreset} - case presets.None: - providerSettings.Ciphers = []string{"none"} - providerSettings.Auth = "none" - providerSettings.CAs = []string{caNormalPreset} default: // strong providerSettings.Ciphers = []string{openvpn.AES256cbc} providerSettings.Auth = openvpn.SHA256 diff --git a/internal/provider/privateinternetaccess/presets/presets.go b/internal/provider/privateinternetaccess/presets/presets.go index d66efc09..d81da36d 100644 --- a/internal/provider/privateinternetaccess/presets/presets.go +++ b/internal/provider/privateinternetaccess/presets/presets.go @@ -1,7 +1,6 @@ package presets const ( - None = "none" Normal = "normal" Strong = "strong" )