From b00279bc61a386f95a3aeb7e7366d127ecc4a466 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Wed, 29 Jul 2026 06:06:09 +0000 Subject: [PATCH] hotfix(portforwarding): allow setting ports when no custom code is running --- internal/portforward/service/service.go | 4 +++- internal/vpn/portforward.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/portforward/service/service.go b/internal/portforward/service/service.go index 2bb2777b..0e5c12be 100644 --- a/internal/portforward/service/service.go +++ b/internal/portforward/service/service.go @@ -6,6 +6,7 @@ import ( "fmt" "net/http" "slices" + "strings" "sync" ) @@ -60,7 +61,8 @@ func (s *Service) SetPortsForwarded(ctx context.Context, ports []uint16) (err er s.portMutex.Lock() defer s.portMutex.Unlock() - if s.settings.PortForwarder != nil { + hasPortForwardingCodeRunning := !strings.HasSuffix(s.settings.PortForwarder.Name(), "[not supported]") + if hasPortForwardingCodeRunning { return errors.New("setting port forwarded at runtime is not supported with internally running port forwarding code") } diff --git a/internal/vpn/portforward.go b/internal/vpn/portforward.go index ec8a7862..8b15cebc 100644 --- a/internal/vpn/portforward.go +++ b/internal/vpn/portforward.go @@ -55,7 +55,7 @@ func newNoPortForwarder(providerName string) *noPortForwarder { } func (n *noPortForwarder) Name() string { - return n.providerName + return n.providerName + " [not supported]" } func (n *noPortForwarder) PortForward(context.Context, pfutils.PortForwardObjects) (