PR feedback

.github/workflows/ci.yml

@@ -65,7 +65,7 @@ jobs:
 
       - name: Run integration tests in test container
         run: |
-          docker run --rm --entrypoint "go test -tags=integration ./internal/restrictednet" test-container
+          docker run --rm --entrypoint go test-container test -tags=integration ./internal/restrictednet
 
       - name: Verify dev cross platform compatibility
         run: docker build --target xcompile .

internal/restrictednet/client.go

@@ -62,6 +62,8 @@ func (c *Client) OpenHTTPSByHostname(ctx context.Context, hostname string) (
 	portUint, err := strconv.ParseUint(portStr, 10, 16)
 	if err != nil {
 		return nil, nil, fmt.Errorf("parsing port: %w", err)
+	} else if portUint == 0 {
+		return nil, nil, errors.New("destination port cannot be 0")
 	}
 	port := uint16(portUint)
 

internal/restrictednet/helpers_test.go

@@ -1,3 +1,5 @@
+//go:build integration
+
 package restrictednet
 
 func ptrTo[T any](value T) *T {

internal/restrictednet/https.go

@@ -73,7 +73,6 @@ func newHTTPSClient(destinationTLSName string, dial dialFunc) *http.Client {
 		MaxIdleConns:        1,
 		MaxIdleConnsPerHost: 1,
 		MaxConnsPerHost:     1,
-		IdleConnTimeout:     time.Second,
 		TLSClientConfig: &tls.Config{
 			MinVersion: tls.VersionTLS12,
 			ServerName: destinationTLSName,