chore: do not use sentinel errors when unneeded

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
Quentin McGaw
2026-05-02 00:50:16 +00:00
parent 9b6f048fe8
commit 4a78989d9d
172 changed files with 666 additions and 1433 deletions
+2 -5
View File
@@ -2,7 +2,6 @@ package vpn
import (
"context"
"errors"
"fmt"
"github.com/qdm12/gluetun/internal/portforward"
@@ -55,8 +54,6 @@ func newNoPortForwarder(providerName string) *noPortForwarder {
}
}
var ErrPortForwardingNotSupported = errors.New("custom port forwarding obtention is not supported")
func (n *noPortForwarder) Name() string {
return n.providerName
}
@@ -64,9 +61,9 @@ func (n *noPortForwarder) Name() string {
func (n *noPortForwarder) PortForward(context.Context, pfutils.PortForwardObjects) (
internalToExternalPorts map[uint16]uint16, err error,
) {
return nil, fmt.Errorf("%w: for %s", ErrPortForwardingNotSupported, n.providerName)
return nil, fmt.Errorf("custom port forwarding obtention is not supported: for %s", n.providerName)
}
func (n *noPortForwarder) KeepPortForward(context.Context, pfutils.PortForwardObjects) (err error) {
return fmt.Errorf("%w: for %s", ErrPortForwardingNotSupported, n.providerName)
return fmt.Errorf("custom port forwarding obtention is not supported: for %s", n.providerName)
}