chore: do not use sentinel errors when unneeded

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
Quentin McGaw
2026-05-02 00:50:16 +00:00
parent 9b6f048fe8
commit 4a78989d9d
172 changed files with 666 additions and 1433 deletions
+2 -6
View File
@@ -44,8 +44,6 @@ func GetMessage(ctx context.Context, buildInfo models.BuildInformation,
nil
}
var errReleaseNotFound = errors.New("release not found")
func getLatestRelease(ctx context.Context, client *http.Client) (tagName, name string, time time.Time, err error) {
releases, err := getGithubReleases(ctx, client)
if err != nil {
@@ -61,11 +59,9 @@ func getLatestRelease(ctx context.Context, client *http.Client) (tagName, name s
}
return release.TagName, release.Name, release.PublishedAt, nil
}
return "", "", time, fmt.Errorf("%w", errReleaseNotFound)
return "", "", time, errors.New("release not found")
}
var errCommitNotFound = errors.New("commit not found")
func getCommitsSince(ctx context.Context, client *http.Client, commitShort string) (n int, err error) {
commits, err := getGithubCommits(ctx, client)
if err != nil {
@@ -77,5 +73,5 @@ func getCommitsSince(ctx context.Context, client *http.Client, commitShort strin
}
n++
}
return 0, fmt.Errorf("%w: %s", errCommitNotFound, commitShort)
return 0, fmt.Errorf("commit not found: %s", commitShort)
}