chore: do not use sentinel errors when unneeded

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
Quentin McGaw
2026-05-02 00:50:16 +00:00
parent 9b6f048fe8
commit 4a78989d9d
172 changed files with 666 additions and 1433 deletions
+1 -4
View File
@@ -3,7 +3,6 @@ package version
import (
"context"
"encoding/json"
"errors"
"fmt"
"net/http"
"time"
@@ -25,8 +24,6 @@ type githubCommit struct {
} `json:"commit"`
}
var errHTTPStatusCode = errors.New("bad response HTTP status code")
func getGithubReleases(ctx context.Context, client *http.Client) (releases []githubRelease, err error) {
// Define a timeout since the default client has a large timeout and we don't
// want to wait too long.
@@ -47,7 +44,7 @@ func getGithubReleases(ctx context.Context, client *http.Client) (releases []git
defer response.Body.Close()
if response.StatusCode != http.StatusOK {
return nil, fmt.Errorf("%w: %d %s", errHTTPStatusCode,
return nil, fmt.Errorf("bad response HTTP status code: %d %s",
response.StatusCode, response.Status)
}