chore: do not use sentinel errors when unneeded

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
Quentin McGaw
2026-05-02 00:50:16 +00:00
parent 9b6f048fe8
commit 4a78989d9d
172 changed files with 666 additions and 1433 deletions
+1 -4
View File
@@ -2,15 +2,12 @@ package html
import (
"context"
"errors"
"fmt"
"net/http"
"golang.org/x/net/html"
)
var ErrHTTPStatusCodeNotOK = errors.New("HTTP status code is not OK")
func Fetch(ctx context.Context, client *http.Client, url string) (
rootNode *html.Node, err error,
) {
@@ -25,7 +22,7 @@ func Fetch(ctx context.Context, client *http.Client, url string) (
}
if response.StatusCode != http.StatusOK {
return nil, fmt.Errorf("%w: %d %s", ErrHTTPStatusCodeNotOK,
return nil, fmt.Errorf("HTTP status code not OK: %d %s",
response.StatusCode, response.Status)
}