chore: do not use sentinel errors when unneeded

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
Quentin McGaw
2026-05-02 00:50:16 +00:00
parent 9b6f048fe8
commit 4a78989d9d
172 changed files with 666 additions and 1433 deletions
+4 -8
View File
@@ -19,8 +19,6 @@ import (
func Test_GetConnection(t *testing.T) {
t.Parallel()
errTest := errors.New("test error")
testCases := map[string]struct {
provider string
filteredServers []models.Server
@@ -30,12 +28,10 @@ func Test_GetConnection(t *testing.T) {
ipv6Supported bool
randSource rand.Source
connection models.Connection
errWrapped error
errMessage string
}{
"storage filter error": {
filterError: errTest,
errWrapped: errTest,
filterError: errors.New("test error"),
errMessage: "filtering servers: test error",
},
"server without IPs": {
@@ -50,7 +46,6 @@ func Test_GetConnection(t *testing.T) {
OpenVPNUDPPort: 1,
WireguardPort: 1,
},
errWrapped: ErrNoConnectionToPickFrom,
errMessage: "no connection to pick from",
},
"OpenVPN server with hostname": {
@@ -199,9 +194,10 @@ func Test_GetConnection(t *testing.T) {
testCase.randSource)
assert.Equal(t, testCase.connection, connection)
assert.ErrorIs(t, err, testCase.errWrapped)
if testCase.errWrapped != nil {
if testCase.errMessage != "" {
assert.EqualError(t, err, testCase.errMessage)
} else {
assert.NoError(t, err)
}
})
}