mirror of
https://github.com/qdm12/gluetun.git
synced 2026-06-20 19:04:11 +02:00
chore: do not use sentinel errors when unneeded
- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly - only use sentinel errors when it has to be checked using `errors.Is` - replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error - exclude the sentinel error definition requirement from .golangci.yml - update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
@@ -22,8 +22,6 @@ func (s roundTripFunc) RoundTrip(r *http.Request) (*http.Response, error) {
|
||||
func Test_Provider_PortForward(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
errTest := errors.New("test error")
|
||||
|
||||
canceledCtx, cancel := context.WithCancel(context.Background())
|
||||
cancel()
|
||||
|
||||
@@ -59,7 +57,7 @@ func Test_Provider_PortForward(t *testing.T) {
|
||||
assert.Equal(t,
|
||||
"https://connect.pvdatanet.com/v3/Api/port?ip[]=10.10.10.10",
|
||||
r.URL.String())
|
||||
return nil, errTest
|
||||
return nil, errors.New("test error")
|
||||
}),
|
||||
},
|
||||
},
|
||||
@@ -156,7 +154,7 @@ func Test_Provider_PortForward(t *testing.T) {
|
||||
}),
|
||||
},
|
||||
},
|
||||
errMessage: "port forwarded not found: in status \"no port here\"",
|
||||
errMessage: "port forwarded not found in status \"no port here\"",
|
||||
},
|
||||
"port_too_big": {
|
||||
ctx: context.Background(),
|
||||
|
||||
Reference in New Issue
Block a user