chore: do not use sentinel errors when unneeded

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error

internal/provider/fastestvpn/updater/api.go

@@ -3,14 +3,11 @@ package updater
 import (
 	"bytes"
 	"context"
-	"errors"
 	"fmt"
 	"io"
 	"net/http"
 	"net/url"
 	"strings"
-
-	"github.com/qdm12/gluetun/internal/provider/common"
 )
 
 type apiServer struct {
@@ -19,8 +16,6 @@ type apiServer struct {
 	hostname string
 }
 
-var ErrDataMalformed = errors.New("data is malformed")
-
 const apiURL = "https://support.fastestvpn.com/wp-admin/admin-ajax.php"
 
 // The API URL and requests are shamelessly taken from network operations
@@ -49,7 +44,7 @@ func fetchAPIServers(ctx context.Context, client *http.Client, protocol string)
 
 	if response.StatusCode != http.StatusOK {
 		_ = response.Body.Close()
-		return nil, fmt.Errorf("%w: %d", common.ErrHTTPStatusCodeNotOK, response.StatusCode)
+		return nil, fmt.Errorf("HTTP status code not OK: %d", response.StatusCode)
 	}
 
 	data, err := io.ReadAll(response.Body)
@@ -79,8 +74,8 @@ func fetchAPIServers(ctx context.Context, client *http.Client, protocol string)
 		for i := range numberOfTDBlocks {
 			tdBlock := getNextTDBlock(trBlock)
 			if tdBlock == nil {
-				return nil, fmt.Errorf("%w: expected 3 <td> blocks in <tr> block %q",
-					ErrDataMalformed, string(trBlock))
+				return nil, fmt.Errorf("data is malformed: expected 3 <td> blocks in <tr> block %q",
+					string(trBlock))
 			}
 			trBlock = trBlock[len(tdBlock):]
 

internal/provider/fastestvpn/updater/api_test.go

@@ -8,7 +8,6 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/qdm12/gluetun/internal/provider/common"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -21,8 +20,6 @@ func (f roundTripFunc) RoundTrip(r *http.Request) (*http.Response, error) {
 func Test_fechAPIServers(t *testing.T) {
 	t.Parallel()
 
-	errTest := errors.New("test error")
-
 	testCases := map[string]struct {
 		ctx            context.Context
 		protocol       string
@@ -31,7 +28,6 @@ func Test_fechAPIServers(t *testing.T) {
 		responseBody   io.ReadCloser
 		transportErr   error
 		servers        []apiServer
-		errWrapped     error
 		errMessage     string
 	}{
 		"transport_error": {
@@ -39,8 +35,7 @@ func Test_fechAPIServers(t *testing.T) {
 			protocol:       "tcp",
 			requestBody:    "action=vpn_servers&protocol=tcp",
 			responseStatus: http.StatusOK,
-			transportErr:   errTest,
-			errWrapped:     errTest,
+			transportErr:   errors.New("test error"),
 			errMessage: `sending request: Post ` +
 				`"https://support.fastestvpn.com/wp-admin/admin-ajax.php": ` +
 				`test error`,
@@ -50,7 +45,6 @@ func Test_fechAPIServers(t *testing.T) {
 			protocol:       "tcp",
 			requestBody:    "action=vpn_servers&protocol=tcp",
 			responseStatus: http.StatusNotFound,
-			errWrapped:     common.ErrHTTPStatusCodeNotOK,
 			errMessage:     "HTTP status code not OK: 404",
 		},
 		"empty_data": {
@@ -110,9 +104,10 @@ func Test_fechAPIServers(t *testing.T) {
 
 			entries, err := fetchAPIServers(testCase.ctx, client, testCase.protocol)
 
-			assert.ErrorIs(t, err, testCase.errWrapped)
-			if testCase.errWrapped != nil {
+			if testCase.errMessage != "" {
 				assert.EqualError(t, err, testCase.errMessage)
+			} else {
+				assert.NoError(t, err)
 			}
 			assert.Equal(t, testCase.servers, entries)
 		})