chore: do not use sentinel errors when unneeded

mirror of https://github.com/qdm12/gluetun.git synced 2026-06-15 16:04:08 +02:00

- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error

This commit is contained in:

Quentin McGaw

2026-05-02 00:50:16 +00:00

parent 9b6f048fe8

commit 4a78989d9d

172 changed files with 666 additions and 1433 deletions

									
										internal/provider/common/portforward.go
									
		-5
	
												View File
											
				@@ -1,5 +0,0 @@

				package common

				import "errors"

				var ErrPortForwardNotSupported = errors.New("port forwarding not supported")