mirror of
https://github.com/qdm12/gluetun.git
synced 2026-05-06 20:10:11 +02:00
chore: do not use sentinel errors when unneeded
- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly - only use sentinel errors when it has to be checked using `errors.Is` - replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error - exclude the sentinel error definition requirement from .golangci.yml - update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
This commit is contained in:
@@ -2,7 +2,6 @@ package pprof
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"time"
|
||||
|
||||
"github.com/qdm12/gluetun/internal/httpserver"
|
||||
@@ -51,18 +50,13 @@ func (s *Settings) OverrideWith(other Settings) {
|
||||
s.HTTPServer.OverrideWith(other.HTTPServer)
|
||||
}
|
||||
|
||||
var (
|
||||
ErrBlockProfileRateNegative = errors.New("block profile rate cannot be negative")
|
||||
ErrMutexProfileRateNegative = errors.New("mutex profile rate cannot be negative")
|
||||
)
|
||||
|
||||
func (s Settings) Validate() (err error) {
|
||||
if *s.BlockProfileRate < 0 {
|
||||
return fmt.Errorf("%w", ErrBlockProfileRateNegative)
|
||||
return errors.New("block profile rate cannot be negative")
|
||||
}
|
||||
|
||||
if *s.MutexProfileRate < 0 {
|
||||
return fmt.Errorf("%w", ErrMutexProfileRateNegative)
|
||||
return errors.New("mutex profile rate cannot be negative")
|
||||
}
|
||||
|
||||
return s.HTTPServer.Validate()
|
||||
|
||||
Reference in New Issue
Block a user