From e3c26aa5faf615971a4525193341cdcdb3597a31 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Tue, 16 Dec 2025 21:06:56 -0800
Subject: [PATCH] remove selection dialog from certain list views

---
 .../components/item-list/item-grid-list/item-grid-list.tsx    | 4 +++-
 .../components/item-list/item-table-list/item-table-list.tsx  | 4 +++-
 .../features/albums/components/album-detail-content.tsx       | 1 +
 .../artists/components/album-artist-detail-content.tsx        | 1 +
 .../routes/album-artist-detail-top-songs-list-route.tsx       | 1 +
 src/renderer/features/now-playing/components/play-queue.tsx   | 1 +
 .../features/similar-songs/components/similar-songs-list.tsx  | 1 +
 7 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/renderer/components/item-list/item-grid-list/item-grid-list.tsx b/src/renderer/components/item-list/item-grid-list/item-grid-list.tsx
index b7c6f185e..cbed4b32f 100644
--- a/src/renderer/components/item-list/item-grid-list/item-grid-list.tsx
+++ b/src/renderer/components/item-list/item-grid-list/item-grid-list.tsx
@@ -287,6 +287,7 @@ export interface ItemGridListProps {
     enableDrag?: boolean;
     enableExpansion?: boolean;
     enableSelection?: boolean;
+    enableSelectionDialog?: boolean;
     gap?: 'lg' | 'md' | 'sm' | 'xl' | 'xs';
     getRowId?: ((item: unknown) => string) | string;
     initialTop?: {
@@ -309,6 +310,7 @@ const BaseItemGridList = ({
     enableDrag = true,
     enableExpansion = false,
     enableSelection = true,
+    enableSelectionDialog = true,
     gap = 'sm',
     getRowId,
     initialTop,
@@ -745,7 +747,7 @@ const BaseItemGridList = ({
             </AutoSizer>
             <AnimatePresence presenceAffectsLayout>
                 <ExpandedContainer internalState={internalState} itemType={itemType} />
-                <SelectionDialog internalState={internalState} />
+                {enableSelectionDialog && <SelectionDialog internalState={internalState} />}
             </AnimatePresence>
         </motion.div>
     );
diff --git a/src/renderer/components/item-list/item-table-list/item-table-list.tsx b/src/renderer/components/item-list/item-table-list/item-table-list.tsx
index 454a8f029..9308f2bbf 100644
--- a/src/renderer/components/item-list/item-table-list/item-table-list.tsx
+++ b/src/renderer/components/item-list/item-table-list/item-table-list.tsx
@@ -673,6 +673,7 @@ interface ItemTableListProps {
     enableHorizontalBorders?: boolean;
     enableRowHoverHighlight?: boolean;
     enableSelection?: boolean;
+    enableSelectionDialog?: boolean;
     enableStickyGroupRows?: boolean;
     enableStickyHeader?: boolean;
     enableVerticalBorders?: boolean;
@@ -714,6 +715,7 @@ const BaseItemTableList = ({
     enableHorizontalBorders = false,
     enableRowHoverHighlight = true,
     enableSelection = true,
+    enableSelectionDialog = true,
     enableStickyGroupRows = false,
     enableStickyHeader = false,
     enableVerticalBorders = false,
@@ -2319,7 +2321,7 @@ const BaseItemTableList = ({
                 totalRowCount={totalRowCount}
             />
             <ExpandedContainer internalState={internalState} itemType={itemType} />
-            <SelectionDialog internalState={internalState} />
+            {enableSelectionDialog && <SelectionDialog internalState={internalState} />}
         </motion.div>
     );
 };
diff --git a/src/renderer/features/albums/components/album-detail-content.tsx b/src/renderer/features/albums/components/album-detail-content.tsx
index 72df8dfe3..398827f73 100644
--- a/src/renderer/features/albums/components/album-detail-content.tsx
+++ b/src/renderer/features/albums/components/album-detail-content.tsx
@@ -677,6 +677,7 @@ const AlbumDetailSongsTable = ({ songs }: AlbumDetailSongsTableProps) => {
                 enableHorizontalBorders={tableConfig.enableHorizontalBorders}
                 enableRowHoverHighlight={tableConfig.enableRowHoverHighlight}
                 enableSelection
+                enableSelectionDialog={false}
                 enableStickyGroupRows
                 enableStickyHeader
                 enableVerticalBorders={tableConfig.enableVerticalBorders}
diff --git a/src/renderer/features/artists/components/album-artist-detail-content.tsx b/src/renderer/features/artists/components/album-artist-detail-content.tsx
index 72981d9ec..cf71a41fd 100644
--- a/src/renderer/features/artists/components/album-artist-detail-content.tsx
+++ b/src/renderer/features/artists/components/album-artist-detail-content.tsx
@@ -305,6 +305,7 @@ const AlbumArtistMetadataTopSongs = ({
                     />
                 </Group>
                 <ItemTableList
+                    enableSelectionDialog={false}
                     activeRowId={currentSongId}
                     autoFitColumns={tableConfig.autoFitColumns}
                     CellComponent={ItemTableListColumn}
diff --git a/src/renderer/features/artists/routes/album-artist-detail-top-songs-list-route.tsx b/src/renderer/features/artists/routes/album-artist-detail-top-songs-list-route.tsx
index 30e645cd1..62e639b5b 100644
--- a/src/renderer/features/artists/routes/album-artist-detail-top-songs-list-route.tsx
+++ b/src/renderer/features/artists/routes/album-artist-detail-top-songs-list-route.tsx
@@ -127,6 +127,7 @@ const AlbumArtistDetailTopSongsListRoute = () => {
                         enableHorizontalBorders={tableConfig.enableHorizontalBorders}
                         enableRowHoverHighlight={tableConfig.enableRowHoverHighlight}
                         enableSelection
+                        enableSelectionDialog={false}
                         enableVerticalBorders={tableConfig.enableVerticalBorders}
                         itemType={LibraryItem.SONG}
                         onColumnReordered={handleColumnReordered}
diff --git a/src/renderer/features/now-playing/components/play-queue.tsx b/src/renderer/features/now-playing/components/play-queue.tsx
index 5ddb73809..a11446ef7 100644
--- a/src/renderer/features/now-playing/components/play-queue.tsx
+++ b/src/renderer/features/now-playing/components/play-queue.tsx
@@ -169,6 +169,7 @@ export const PlayQueue = forwardRef<ItemListHandle, QueueProps>(({ listKey, sear
                 enableHorizontalBorders={table.enableHorizontalBorders}
                 enableRowHoverHighlight={table.enableRowHoverHighlight}
                 enableSelection
+                enableSelectionDialog={false}
                 enableVerticalBorders={table.enableVerticalBorders}
                 getRowId="_uniqueId"
                 groups={groups.length > 0 ? groups : undefined}
diff --git a/src/renderer/features/similar-songs/components/similar-songs-list.tsx b/src/renderer/features/similar-songs/components/similar-songs-list.tsx
index 9ecfca648..4d5dea19b 100644
--- a/src/renderer/features/similar-songs/components/similar-songs-list.tsx
+++ b/src/renderer/features/similar-songs/components/similar-songs-list.tsx
@@ -55,6 +55,7 @@ export const SimilarSongsList = ({ count, song }: SimilarSongsListProps) => {
     return (
         <ErrorBoundary FallbackComponent={ErrorFallback}>
             <ItemTableList
+                enableSelectionDialog={false}
                 autoFitColumns={table?.autoFitColumns}
                 CellComponent={ItemTableListColumn}
                 columns={table?.columns || []}