vanja/feishin
1
0
Fork 0
mirror of https://github.com/jeffvli/feishin.git synced 2026-05-14 20:40:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

properly handle disableArtistFilter and disableGenreFilter props for all list filters

Browse Source
This commit is contained in:
jeffvli
2026-01-18 14:07:52 -08:00
parent dad3d10a83
commit c3d4f6cacd
7 changed files with 91 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/features/shared/components/list-filters.tsx
+16 -3
View File
@@ -39,7 +39,7 @@ export const isFilterValueSet = (value: unknown): boolean => {
export const ListFiltersModal = ({ isActive, itemType }: ListFiltersProps) => {
const { t } = useTranslation();
const server = useCurrentServer();
const { isSidebarOpen, setIsSidebarOpen } = useListContext();
const { isSidebarOpen, pageKey, setIsSidebarOpen } = useListContext();
const serverType = server.type;
@@ -53,6 +53,9 @@ export const ListFiltersModal = ({ isActive, itemType }: ListFiltersProps) => {
const canPin = Boolean(setIsSidebarOpen);
const disableArtistFilter = pageKey === ItemListKey.ALBUM_ARTIST_ALBUM;
const disableGenreFilter = pageKey === ItemListKey.GENRE_ALBUM;
return (
<>
<FilterButton isActive={isActive} onClick={handlers.toggle} />
@@ -81,7 +84,10 @@ export const ListFiltersModal = ({ isActive, itemType }: ListFiltersProps) => {
</Group>
}
>
<FilterComponent />
<FilterComponent
disableArtistFilter={disableArtistFilter}
disableGenreFilter={disableGenreFilter}
/>
</Modal>
</>
);
@@ -91,11 +97,18 @@ export const ListFilters = ({ itemType }: ListFiltersProps) => {
const server = useCurrentServer();
const serverType = server.type;
const FilterComponent = FILTERS[serverType][itemType];
const { pageKey } = useListContext();
const disableArtistFilter = pageKey === ItemListKey.ALBUM_ARTIST_ALBUM;
const disableGenreFilter = pageKey === ItemListKey.GENRE_ALBUM;
return (
<ComponentErrorBoundary>
<Suspense fallback={<Spinner container />}>
<FilterComponent />
<FilterComponent
disableArtistFilter={disableArtistFilter}
disableGenreFilter={disableGenreFilter}
/>
</Suspense>
</ComponentErrorBoundary>
);