rework player events to use properties object instead of flat value

This commit is contained in:
jeffvli
2025-11-02 18:52:59 -08:00
parent 015c3004f5
commit b1fa7e4e09
3 changed files with 61 additions and 53 deletions
@@ -17,26 +17,32 @@ export interface PlayerEvents {
}
export interface PlayerEventsCallbacks {
onCurrentTrackChange?: (
track: { index: number; track: QueueSong | undefined },
prevTrack: { index: number; track: QueueSong | undefined },
onCurrentSongChange?: (
properties: { index: number; song: QueueSong | undefined },
prev: { index: number; song: QueueSong | undefined },
) => void;
onPlayerMute?: (muted: boolean, prevMuted: boolean) => void;
onPlayerProgress?: (timestamp: number, prevTimestamp: number) => void;
onPlayerQueueChange?: (queue: QueueData, prevQueue: QueueData) => void;
onPlayerSeek?: (seconds: number, prevSeconds: number) => void;
onPlayerSeekToTimestamp?: (timestamp: number, prevTimestamp: number) => void;
onPlayerSpeed?: (speed: number, prevSpeed: number) => void;
onPlayerStatus?: (status: PlayerStatus, prevStatus: PlayerStatus) => void;
onPlayerVolume?: (volume: number, prevVolume: number) => void;
onPlayerMute?: (properties: { muted: boolean }, prev: { muted: boolean }) => void;
onPlayerProgress?: (properties: { timestamp: number }, prev: { timestamp: number }) => void;
onPlayerQueueChange?: (queue: QueueData, prev: QueueData) => void;
onPlayerSeek?: (properties: { seconds: number }, prev: { seconds: number }) => void;
onPlayerSeekToTimestamp?: (
properties: { timestamp: number },
prev: { timestamp: number },
) => void;
onPlayerSpeed?: (properties: { speed: number }, prev: { speed: number }) => void;
onPlayerStatus?: (
properties: { song: QueueSong | undefined; status: PlayerStatus },
prev: { song: QueueSong | undefined; status: PlayerStatus },
) => void;
onPlayerVolume?: (properties: { volume: number }, prev: { volume: number }) => void;
}
export function createPlayerEvents(callbacks: PlayerEventsCallbacks): PlayerEvents {
const unsubscribers: (() => void)[] = [];
// Subscribe to current track changes
if (callbacks.onCurrentTrackChange) {
const unsubscribe = subscribeCurrentTrack(callbacks.onCurrentTrackChange);
if (callbacks.onCurrentSongChange) {
const unsubscribe = subscribeCurrentTrack(callbacks.onCurrentSongChange);
unsubscribers.push(unsubscribe);
}
@@ -1,25 +1,11 @@
import { useEffect } from 'react';
import { createPlayerEvents } from '/@/renderer/components/audio-player/listener/player-events';
import { QueueData } from '/@/renderer/store';
import { QueueSong } from '/@/shared/types/domain-types';
import { PlayerStatus } from '/@/shared/types/types';
import {
createPlayerEvents,
PlayerEventsCallbacks,
} from '/@/renderer/components/audio-player/listener/player-events';
export interface PlayerEvents {
onCurrentTrackChange?: (
track: { index: number; track: QueueSong | undefined },
prevTrack: { index: number; track: QueueSong | undefined },
) => void;
onPlayerMute?: (muted: boolean, prevMuted: boolean) => void;
onPlayerProgress?: (timestamp: number, prevTimestamp: number) => void;
onPlayerQueueChange?: (queue: QueueData, prevQueue: QueueData) => void;
onPlayerSeekToTimestamp?: (timestamp: number, prevTimestamp: number) => void;
onPlayerSpeed?: (speed: number, prevSpeed: number) => void;
onPlayerStatus?: (status: PlayerStatus, prevStatus: PlayerStatus) => void;
onPlayerVolume?: (volume: number, prevVolume: number) => void;
}
export function usePlayerEvents(callbacks: PlayerEvents, deps: React.DependencyList) {
export function usePlayerEvents(callbacks: PlayerEventsCallbacks, deps: React.DependencyList) {
useEffect(() => {
const engine = createPlayerEvents(callbacks);