From a7b6afd8a6be64c32d0162bba1193b4933e0fd7c Mon Sep 17 00:00:00 2001 From: jeffvli Date: Tue, 4 Aug 2026 22:11:17 -0700 Subject: [PATCH] hide lyric translation line if same as parent (#2311) --- src/renderer/features/lyrics/karaoke-lyric-line.tsx | 4 +++- src/renderer/features/lyrics/lyric-line.tsx | 2 +- src/renderer/features/lyrics/synchronized-karaoke-lyrics.tsx | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/renderer/features/lyrics/karaoke-lyric-line.tsx b/src/renderer/features/lyrics/karaoke-lyric-line.tsx index 3ca5ed98d..9052356b0 100644 --- a/src/renderer/features/lyrics/karaoke-lyric-line.tsx +++ b/src/renderer/features/lyrics/karaoke-lyric-line.tsx @@ -181,6 +181,7 @@ export const KaraokeLyricLine = memo( pronunciationText, romajiCueLines, romajiText, + text, translatedText, translationCueLines, ...props @@ -258,6 +259,7 @@ export const KaraokeLyricLine = memo( styles.overlayLine, )} {translationCueLine && + translationCueLine.value !== cueLine.value && renderOverlayCueLineRow( translationCueLine, lineIndex, @@ -276,7 +278,7 @@ export const KaraokeLyricLine = memo( }} /> )} - {!hasSyncedTranslation && translatedText && ( + {!hasSyncedTranslation && translatedText && translatedText !== text && ( )} - {translatedText && ( + {translatedText && translatedText !== text && ( )} diff --git a/src/renderer/features/lyrics/synchronized-karaoke-lyrics.tsx b/src/renderer/features/lyrics/synchronized-karaoke-lyrics.tsx index f2170f4f7..1af50a1de 100644 --- a/src/renderer/features/lyrics/synchronized-karaoke-lyrics.tsx +++ b/src/renderer/features/lyrics/synchronized-karaoke-lyrics.tsx @@ -439,6 +439,7 @@ export const SynchronizedKaraokeLyrics = ({ ? (syncedRomajiLyrics[idx] ?? null) : undefined } + text={getLyricLineText(rawLine)} translatedText={translationText} translationCueLines={translationCueLines} />