remove scroll shadows from fullscreen player

This commit is contained in:
jeffvli
2026-01-03 03:23:58 -08:00
parent 968d991a1a
commit 8c91f1c52d
4 changed files with 182 additions and 163 deletions
@@ -103,6 +103,7 @@ interface VirtualizedTableGridProps {
enableHeader: boolean; enableHeader: boolean;
enableHorizontalBorders: boolean; enableHorizontalBorders: boolean;
enableRowHoverHighlight: boolean; enableRowHoverHighlight: boolean;
enableScrollShadow: boolean;
enableSelection: boolean; enableSelection: boolean;
enableVerticalBorders: boolean; enableVerticalBorders: boolean;
getRowHeight: (index: number, cellProps: TableItemProps) => number; getRowHeight: (index: number, cellProps: TableItemProps) => number;
@@ -146,6 +147,7 @@ const VirtualizedTableGrid = ({
enableHeader, enableHeader,
enableHorizontalBorders, enableHorizontalBorders,
enableRowHoverHighlight, enableRowHoverHighlight,
enableScrollShadow,
enableSelection, enableSelection,
enableVerticalBorders, enableVerticalBorders,
getRowHeight, getRowHeight,
@@ -429,7 +431,7 @@ const VirtualizedTableGrid = ({
/> />
</div> </div>
)} )}
{enableHeader && showTopShadow && ( {enableHeader && enableScrollShadow && showTopShadow && (
<div className={styles.itemTableTopScrollShadow} /> <div className={styles.itemTableTopScrollShadow} />
)} )}
{!!pinnedLeftColumnCount && ( {!!pinnedLeftColumnCount && (
@@ -489,7 +491,7 @@ const VirtualizedTableGrid = ({
/> />
</div> </div>
)} )}
{enableHeader && showTopShadow && ( {enableHeader && enableScrollShadow && showTopShadow && (
<div className={styles.itemTableTopScrollShadow} /> <div className={styles.itemTableTopScrollShadow} />
)} )}
<div className={styles.itemTableGridContainer} ref={mergedRowRef}> <div className={styles.itemTableGridContainer} ref={mergedRowRef}>
@@ -507,10 +509,10 @@ const VirtualizedTableGrid = ({
return getRowHeight(index + pinnedRowCount, cellProps); return getRowHeight(index + pinnedRowCount, cellProps);
}} }}
/> />
{pinnedLeftColumnCount > 0 && showLeftShadow && ( {pinnedLeftColumnCount > 0 && enableScrollShadow && showLeftShadow && (
<div className={styles.itemTableLeftScrollShadow} /> <div className={styles.itemTableLeftScrollShadow} />
)} )}
{pinnedRightColumnCount > 0 && showRightShadow && ( {pinnedRightColumnCount > 0 && enableScrollShadow && showRightShadow && (
<div className={styles.itemTableRightScrollShadow} /> <div className={styles.itemTableRightScrollShadow} />
)} )}
</div> </div>
@@ -560,7 +562,7 @@ const VirtualizedTableGrid = ({
/> />
</div> </div>
)} )}
{enableHeader && showTopShadow && ( {enableHeader && enableScrollShadow && showTopShadow && (
<div className={styles.itemTableTopScrollShadow} /> <div className={styles.itemTableTopScrollShadow} />
)} )}
<div <div
@@ -607,6 +609,7 @@ const MemoizedVirtualizedTableGrid = memo(VirtualizedTableGrid, (prevProps, next
prevProps.enableHeader === nextProps.enableHeader && prevProps.enableHeader === nextProps.enableHeader &&
prevProps.enableHorizontalBorders === nextProps.enableHorizontalBorders && prevProps.enableHorizontalBorders === nextProps.enableHorizontalBorders &&
prevProps.enableRowHoverHighlight === nextProps.enableRowHoverHighlight && prevProps.enableRowHoverHighlight === nextProps.enableRowHoverHighlight &&
prevProps.enableScrollShadow === nextProps.enableScrollShadow &&
prevProps.enableSelection === nextProps.enableSelection && prevProps.enableSelection === nextProps.enableSelection &&
prevProps.enableVerticalBorders === nextProps.enableVerticalBorders && prevProps.enableVerticalBorders === nextProps.enableVerticalBorders &&
prevProps.getRowHeight === nextProps.getRowHeight && prevProps.getRowHeight === nextProps.getRowHeight &&
@@ -695,6 +698,7 @@ interface ItemTableListProps {
enableHeader?: boolean; enableHeader?: boolean;
enableHorizontalBorders?: boolean; enableHorizontalBorders?: boolean;
enableRowHoverHighlight?: boolean; enableRowHoverHighlight?: boolean;
enableScrollShadow?: boolean;
enableSelection?: boolean; enableSelection?: boolean;
enableSelectionDialog?: boolean; enableSelectionDialog?: boolean;
enableStickyGroupRows?: boolean; enableStickyGroupRows?: boolean;
@@ -737,6 +741,7 @@ const BaseItemTableList = ({
enableHeader = true, enableHeader = true,
enableHorizontalBorders = false, enableHorizontalBorders = false,
enableRowHoverHighlight = true, enableRowHoverHighlight = true,
enableScrollShadow = true,
enableSelection = true, enableSelection = true,
enableStickyGroupRows = false, enableStickyGroupRows = false,
enableStickyHeader = false, enableStickyHeader = false,
@@ -2386,6 +2391,7 @@ const BaseItemTableList = ({
enableHeader={enableHeader} enableHeader={enableHeader}
enableHorizontalBorders={enableHorizontalBorders} enableHorizontalBorders={enableHorizontalBorders}
enableRowHoverHighlight={enableRowHoverHighlight} enableRowHoverHighlight={enableRowHoverHighlight}
enableScrollShadow={enableScrollShadow}
enableSelection={enableSelection} enableSelection={enableSelection}
enableVerticalBorders={enableVerticalBorders} enableVerticalBorders={enableVerticalBorders}
getRowHeight={getRowHeight} getRowHeight={getRowHeight}
@@ -39,11 +39,13 @@ import { DragTarget } from '/@/shared/types/drag-and-drop';
import { ItemListKey, Play, PlayerQueueType } from '/@/shared/types/types'; import { ItemListKey, Play, PlayerQueueType } from '/@/shared/types/types';
type QueueProps = { type QueueProps = {
enableScrollShadow?: boolean;
listKey: ItemListKey; listKey: ItemListKey;
searchTerm: string | undefined; searchTerm: string | undefined;
}; };
export const PlayQueue = forwardRef<ItemListHandle, QueueProps>(({ listKey, searchTerm }, ref) => { export const PlayQueue = forwardRef<ItemListHandle, QueueProps>(
({ enableScrollShadow = true, listKey, searchTerm }, ref) => {
const { table } = useListSettings(listKey) || {}; const { table } = useListSettings(listKey) || {};
const isFetching = useIsPlayerFetching(); const isFetching = useIsPlayerFetching();
@@ -64,7 +66,11 @@ export const PlayQueue = forwardRef<ItemListHandle, QueueProps>(({ listKey, sear
setData(queue.items); setData(queue.items);
if (queueType === PlayerQueueType.PRIORITY && queue.groups && queue.groups.length > 0) { if (
queueType === PlayerQueueType.PRIORITY &&
queue.groups &&
queue.groups.length > 0
) {
const transformedGroups: TableGroupHeader[] = queue.groups.map((group) => ({ const transformedGroups: TableGroupHeader[] = queue.groups.map((group) => ({
itemCount: group.count, itemCount: group.count,
render: (): ReactElement => { render: (): ReactElement => {
@@ -196,6 +202,7 @@ export const PlayQueue = forwardRef<ItemListHandle, QueueProps>(({ listKey, sear
enableHeader enableHeader
enableHorizontalBorders={table.enableHorizontalBorders} enableHorizontalBorders={table.enableHorizontalBorders}
enableRowHoverHighlight={table.enableRowHoverHighlight} enableRowHoverHighlight={table.enableRowHoverHighlight}
enableScrollShadow={enableScrollShadow}
enableSelection enableSelection
enableSelectionDialog={false} enableSelectionDialog={false}
enableVerticalBorders={table.enableVerticalBorders} enableVerticalBorders={table.enableVerticalBorders}
@@ -214,7 +221,8 @@ export const PlayQueue = forwardRef<ItemListHandle, QueueProps>(({ listKey, sear
{isEmpty && <EmptyQueueDropZone />} {isEmpty && <EmptyQueueDropZone />}
</div> </div>
); );
}); },
);
const EmptyQueueDropZone = () => { const EmptyQueueDropZone = () => {
const playerContext = usePlayer(); const playerContext = usePlayer();
@@ -106,7 +106,11 @@ export const FullScreenPlayerQueue = () => {
</Group> </Group>
{activeTab === 'queue' ? ( {activeTab === 'queue' ? (
<div className={styles.queueContainer}> <div className={styles.queueContainer}>
<PlayQueue listKey={ItemListKey.FULL_SCREEN} searchTerm={undefined} /> <PlayQueue
enableScrollShadow={false}
listKey={ItemListKey.FULL_SCREEN}
searchTerm={undefined}
/>
</div> </div>
) : activeTab === 'related' ? ( ) : activeTab === 'related' ? (
<div className={styles.queueContainer}> <div className={styles.queueContainer}>
@@ -64,6 +64,7 @@ export const SimilarSongsList = ({ count, song }: SimilarSongsListProps) => {
enableHeader enableHeader
enableHorizontalBorders={fullScreenTable?.enableHorizontalBorders} enableHorizontalBorders={fullScreenTable?.enableHorizontalBorders}
enableRowHoverHighlight={fullScreenTable?.enableRowHoverHighlight} enableRowHoverHighlight={fullScreenTable?.enableRowHoverHighlight}
enableScrollShadow={false}
enableSelection enableSelection
enableSelectionDialog={false} enableSelectionDialog={false}
enableVerticalBorders={fullScreenTable?.enableVerticalBorders} enableVerticalBorders={fullScreenTable?.enableVerticalBorders}