revert settings to route instead of modal

This commit is contained in:
jeffvli
2025-11-30 01:15:11 -08:00
parent cb3c0fe0d4
commit 8777da9491
3 changed files with 6 additions and 7 deletions
@@ -3,7 +3,6 @@ import { useTranslation } from 'react-i18next';
import { useNavigate } from 'react-router';
import { Command, CommandPalettePages } from '/@/renderer/features/search/components/command';
import { openSettingsModal } from '/@/renderer/features/settings/utils/open-settings-modal';
import { AppRoute } from '/@/renderer/router/routes';
interface GoToCommandsProps {
@@ -37,10 +36,7 @@ export const GoToCommands = ({ handleClose, setPages, setQuery }: GoToCommandsPr
</Command.Item>
<Command.Item
onSelect={() => {
openSettingsModal();
handleClose();
setPages([CommandPalettePages.HOME]);
setQuery('');
goTo(AppRoute.SETTINGS);
}}
>
{t('page.sidebar.settings', { postProcess: 'titleCase' })}
@@ -5,7 +5,7 @@ import { Link, useNavigate } from 'react-router';
import packageJson from '../../../../../package.json';
import { openSettingsModal } from '/@/renderer/features/settings/utils/open-settings-modal';
import { AppRoute } from '/@/renderer/router/routes';
import { useAppStore, useAppStoreActions } from '/@/renderer/store';
import { DropdownMenu, MenuItemProps } from '/@/shared/components/dropdown-menu/dropdown-menu';
import { Icon } from '/@/shared/components/icon/icon';
@@ -184,7 +184,7 @@ export const AppMenu = () => {
icon: 'settings',
id: 'settings',
label: t('page.appMenu.settings', { postProcess: 'sentenceCase' }),
onClick: openSettingsModal,
onClick: () => navigate(AppRoute.SETTINGS),
type: 'item',
},
{
+3
View File
@@ -72,6 +72,8 @@ const SearchRoute = lazy(() => import('/@/renderer/features/search/routes/search
const FavoritesRoute = lazy(() => import('/@/renderer/features/favorites/routes/favorites-route'));
const SettingsRoute = lazy(() => import('/@/renderer/features/settings/routes/settings-route'));
export const AppRouter = () => {
const router = (
<HashRouter>
@@ -93,6 +95,7 @@ export const AppRouter = () => {
<Route element={<HomeRoute />} path={AppRoute.HOME} />
<Route element={<SearchRoute />} path={AppRoute.SEARCH} />
<Route element={<FavoritesRoute />} path={AppRoute.FAVORITES} />
<Route element={<SettingsRoute />} path={AppRoute.SETTINGS} />
<Route
element={<NowPlayingRoute />}
path={AppRoute.NOW_PLAYING}