diff --git a/src/renderer/components/item-list/item-detail-list/columns/album-artist-column.tsx b/src/renderer/components/item-list/item-detail-list/columns/album-artist-column.tsx index 28a3d2087..7269215cf 100644 --- a/src/renderer/components/item-list/item-detail-list/columns/album-artist-column.tsx +++ b/src/renderer/components/item-list/item-detail-list/columns/album-artist-column.tsx @@ -4,7 +4,6 @@ import { JOINED_ARTISTS_MUTED_PROPS, JoinedArtists, } from '/@/renderer/features/albums/components/joined-artists'; -import { Text } from '/@/shared/components/text/text'; export const AlbumArtistColumn = ({ isRowHovered, song }: ItemDetailListCellProps) => { const name = song.albumArtistName?.trim() ?? ''; @@ -12,19 +11,12 @@ export const AlbumArtistColumn = ({ isRowHovered, song }: ItemDetailListCellProp if (!hasArtists) return <> ; - if (!isRowHovered) { - return ( - - {name} - - ); - } - return ( ); diff --git a/src/renderer/components/item-list/item-detail-list/columns/artist-column.tsx b/src/renderer/components/item-list/item-detail-list/columns/artist-column.tsx index b97bebec1..62f50d7d1 100644 --- a/src/renderer/components/item-list/item-detail-list/columns/artist-column.tsx +++ b/src/renderer/components/item-list/item-detail-list/columns/artist-column.tsx @@ -4,7 +4,6 @@ import { JOINED_ARTISTS_MUTED_PROPS, JoinedArtists, } from '/@/renderer/features/albums/components/joined-artists'; -import { Text } from '/@/shared/components/text/text'; export const ArtistColumn = ({ isRowHovered, song }: ItemDetailListCellProps) => { const name = song.artistName?.trim() ?? ''; @@ -12,19 +11,12 @@ export const ArtistColumn = ({ isRowHovered, song }: ItemDetailListCellProps) => if (!hasArtists) return <> ; - if (!isRowHovered) { - return ( - - {name} - - ); - } - return ( ); diff --git a/src/renderer/components/item-list/item-detail-list/item-detail.tsx b/src/renderer/components/item-list/item-detail-list/item-detail.tsx index 3f2f34bae..101ad5b0a 100644 --- a/src/renderer/components/item-list/item-detail-list/item-detail.tsx +++ b/src/renderer/components/item-list/item-detail-list/item-detail.tsx @@ -55,7 +55,6 @@ import { useSettingsStore, useShowRatings } from '/@/renderer/store'; import { formatDateAbsoluteUTC, formatDurationString } from '/@/renderer/utils'; import { ExplicitIndicator } from '/@/shared/components/explicit-indicator/explicit-indicator'; import { Skeleton } from '/@/shared/components/skeleton/skeleton'; -import { Text } from '/@/shared/components/text/text'; import { useDoubleClick } from '/@/shared/hooks/use-double-click'; import { Album, LibraryItem, Song, SongListSort, SortOrder } from '/@/shared/types/domain-types'; import { ItemListKey, Play, TableColumn } from '/@/shared/types/types'; @@ -456,15 +455,12 @@ const MetadataSection = memo(
{!hasArtist ? ( <>  - ) : !isMetadataHovered ? ( - - {item.albumArtistName ?? ''} - ) : ( )} diff --git a/src/renderer/features/albums/components/joined-artists.tsx b/src/renderer/features/albums/components/joined-artists.tsx index 4466c95e1..19c121df8 100644 --- a/src/renderer/features/albums/components/joined-artists.tsx +++ b/src/renderer/features/albums/components/joined-artists.tsx @@ -14,6 +14,7 @@ interface JoinedArtistsProps { artistName: string; artists: AlbumArtist[] | RelatedAlbumArtist[] | RelatedArtist[]; linkProps?: Partial>; + readOnly?: boolean; rootTextProps?: Partial>; } @@ -21,6 +22,7 @@ const JoinedArtistsComponent = ({ artistName, artists, linkProps, + readOnly = false, rootTextProps, }: JoinedArtistsProps) => { const parts: ( @@ -116,7 +118,7 @@ const JoinedArtistsComponent = ({ {artists.map((artist, index) => ( {index > 0 && ', '} - {artist.id ? ( + {artist.id && !readOnly ? ( ) : ( - + {artist.name} )} @@ -157,7 +159,7 @@ const JoinedArtistsComponent = ({ const { artist, text } = part; - if (artist.id) { + if (artist.id && !readOnly) { return ( + {text} ); @@ -185,7 +187,7 @@ const JoinedArtistsComponent = ({ {unmatchedArtists.map((artist, index) => ( {index > 0 && ', '} - {artist.id ? ( + {artist.id && !readOnly ? ( {artist.name} + ) : artist.id ? ( + + {artist.name} + ) : ( {artist.name}