From 73c5292cc1e0b44fdb50857b699d9eff03baf474 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Fri, 26 Dec 2025 02:24:20 -0800
Subject: [PATCH] move the visualizer settings out of error boundary

---
 .../audiomotionanalyzer/visualizer.tsx        | 16 +++++------
 .../components/butternchurn/visualizer.tsx    | 28 ++++++++++---------
 2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/src/renderer/features/visualizer/components/audiomotionanalyzer/visualizer.tsx b/src/renderer/features/visualizer/components/audiomotionanalyzer/visualizer.tsx
index b9a54b97b..af3e3a911 100644
--- a/src/renderer/features/visualizer/components/audiomotionanalyzer/visualizer.tsx
+++ b/src/renderer/features/visualizer/components/audiomotionanalyzer/visualizer.tsx
@@ -217,6 +217,10 @@ const VisualizerInner = () => {
         }
     }, [motion, options]);
 
+    return <div className={styles.visualizer} ref={canvasRef} />;
+};
+
+export const Visualizer = () => {
     return (
         <div className={styles.container}>
             <ActionIcon
@@ -229,15 +233,9 @@ const VisualizerInner = () => {
                 top={0}
                 variant="transparent"
             />
-            <div className={styles.visualizer} ref={canvasRef} />
+            <ComponentErrorBoundary>
+                <VisualizerInner />
+            </ComponentErrorBoundary>
         </div>
     );
 };
-
-export const Visualizer = () => {
-    return (
-        <ComponentErrorBoundary>
-            <VisualizerInner />
-        </ComponentErrorBoundary>
-    );
-};
diff --git a/src/renderer/features/visualizer/components/butternchurn/visualizer.tsx b/src/renderer/features/visualizer/components/butternchurn/visualizer.tsx
index c0d505b2c..e1c0ef346 100644
--- a/src/renderer/features/visualizer/components/butternchurn/visualizer.tsx
+++ b/src/renderer/features/visualizer/components/butternchurn/visualizer.tsx
@@ -294,16 +294,6 @@ const VisualizerInner = () => {
 
     return (
         <div className={styles.container} ref={containerRef}>
-            <ActionIcon
-                className={styles.settingsIcon}
-                icon="settings2"
-                iconProps={{ size: 'lg' }}
-                onClick={openVisualizerSettingsModal}
-                pos="absolute"
-                right={0}
-                top={0}
-                variant="transparent"
-            />
             <canvas className={styles.canvas} ref={canvasRef} />
             {butterchurnSettings.currentPreset && (
                 <Text className={styles['preset-overlay']} isNoSelect size="sm">
@@ -316,8 +306,20 @@ const VisualizerInner = () => {
 
 export const Visualizer = () => {
     return (
-        <ComponentErrorBoundary>
-            <VisualizerInner />
-        </ComponentErrorBoundary>
+        <div className={styles.container} style={{ position: 'relative' }}>
+            <ActionIcon
+                className={styles.settingsIcon}
+                icon="settings2"
+                iconProps={{ size: 'lg' }}
+                onClick={openVisualizerSettingsModal}
+                pos="absolute"
+                right={0}
+                top={0}
+                variant="transparent"
+            />
+            <ComponentErrorBoundary>
+                <VisualizerInner />
+            </ComponentErrorBoundary>
+        </div>
     );
 };