refactor ListConfigMenu as modal

This commit is contained in:
jeffvli
2025-11-14 00:39:47 -08:00
parent fe51b671c7
commit 500947eb1f
@@ -1,4 +1,5 @@
import { ReactNode } from 'react'; import { ReactNode } from 'react';
import { useTranslation } from 'react-i18next';
import i18n from '/@/i18n/i18n'; import i18n from '/@/i18n/i18n';
import { GridConfig } from '/@/renderer/features/shared/components/grid-config'; import { GridConfig } from '/@/renderer/features/shared/components/grid-config';
@@ -7,11 +8,11 @@ import { TableConfig } from '/@/renderer/features/shared/components/table-config
import { useSettingsStore, useSettingsStoreActions } from '/@/renderer/store'; import { useSettingsStore, useSettingsStoreActions } from '/@/renderer/store';
import { Group } from '/@/shared/components/group/group'; import { Group } from '/@/shared/components/group/group';
import { Icon } from '/@/shared/components/icon/icon'; import { Icon } from '/@/shared/components/icon/icon';
import { Popover } from '/@/shared/components/popover/popover'; import { Modal } from '/@/shared/components/modal/modal';
import { ScrollArea } from '/@/shared/components/scroll-area/scroll-area';
import { SegmentedControl } from '/@/shared/components/segmented-control/segmented-control'; import { SegmentedControl } from '/@/shared/components/segmented-control/segmented-control';
import { Stack } from '/@/shared/components/stack/stack'; import { Stack } from '/@/shared/components/stack/stack';
import { Table } from '/@/shared/components/table/table'; import { Table } from '/@/shared/components/table/table';
import { useDisclosure } from '/@/shared/hooks/use-disclosure';
import { ItemListKey, ListDisplayType } from '/@/shared/types/types'; import { ItemListKey, ListDisplayType } from '/@/shared/types/types';
const DISPLAY_TYPES = [ const DISPLAY_TYPES = [
@@ -82,21 +83,21 @@ interface ListConfigMenuProps {
} }
export const ListConfigMenu = (props: ListConfigMenuProps) => { export const ListConfigMenu = (props: ListConfigMenuProps) => {
const { t } = useTranslation();
const displayType = useSettingsStore( const displayType = useSettingsStore(
(state) => state.lists[props.listKey]?.display, (state) => state.lists[props.listKey]?.display,
) as ListDisplayType; ) as ListDisplayType;
const { setList } = useSettingsStoreActions(); const { setList } = useSettingsStoreActions();
const [isOpen, handlers] = useDisclosure(false);
return ( return (
<Popover position="bottom-end" trapFocus width={640}> <>
<Popover.Target> <SettingsButton onClick={handlers.toggle} />
<SettingsButton /> <Modal
</Popover.Target> handlers={handlers}
<Popover.Dropdown> opened={isOpen}
<ScrollArea size="lg"
allowDragScroll title={t('common.configure', { postProcess: 'sentenceCase' })}
scrollX
style={{ height: 'auto', maxHeight: '70dvh', padding: '1rem' }}
> >
<Stack> <Stack>
<SegmentedControl <SegmentedControl
@@ -114,9 +115,8 @@ export const ListConfigMenu = (props: ListConfigMenuProps) => {
/> />
<Config displayType={displayType} {...props} /> <Config displayType={displayType} {...props} />
</Stack> </Stack>
</ScrollArea> </Modal>
</Popover.Dropdown> </>
</Popover>
); );
}; };