mirror of
https://github.com/jeffvli/feishin.git
synced 2026-06-10 22:32:17 +02:00
fix NativeImage state causing crashes in table
This commit is contained in:
@@ -89,11 +89,18 @@ export function BaseImage({
|
|||||||
const effectiveImageRequest =
|
const effectiveImageRequest =
|
||||||
isInSessionCache || !enableDebounce ? rawImageRequest : debouncedImageRequest;
|
isInSessionCache || !enableDebounce ? rawImageRequest : debouncedImageRequest;
|
||||||
|
|
||||||
|
const imageCacheKey = src ?? rawImageRequest?.cacheKey;
|
||||||
|
const trackLoadedInInstance = enableViewport;
|
||||||
|
|
||||||
const [hasLoadedInInstance, setHasLoadedInInstance] = useState(false);
|
const [hasLoadedInInstance, setHasLoadedInInstance] = useState(false);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
setHasLoadedInInstance(false);
|
if (!trackLoadedInInstance) {
|
||||||
}, [effectiveImageRequest?.cacheKey]);
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
setHasLoadedInInstance((current) => (current ? false : current));
|
||||||
|
}, [imageCacheKey, trackLoadedInInstance]);
|
||||||
|
|
||||||
const shouldLoadImage = Boolean(
|
const shouldLoadImage = Boolean(
|
||||||
effectiveImageRequest &&
|
effectiveImageRequest &&
|
||||||
@@ -112,13 +119,13 @@ export function BaseImage({
|
|||||||
});
|
});
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!nativeImage.isLoaded || !effectiveImageRequest?.cacheKey) {
|
if (!trackLoadedInInstance || !nativeImage.isLoaded || !imageCacheKey) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
loadedImageCacheKeys.add(effectiveImageRequest.cacheKey);
|
loadedImageCacheKeys.add(imageCacheKey);
|
||||||
setHasLoadedInInstance(true);
|
setHasLoadedInInstance((current) => (current ? current : true));
|
||||||
}, [effectiveImageRequest?.cacheKey, nativeImage.isLoaded]);
|
}, [imageCacheKey, nativeImage.isLoaded, trackLoadedInInstance]);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<ImageContainer
|
<ImageContainer
|
||||||
|
|||||||
@@ -26,8 +26,11 @@ export function useNativeImage({
|
|||||||
const loadedRequestSignatureRef = useRef<null | string>(null);
|
const loadedRequestSignatureRef = useRef<null | string>(null);
|
||||||
const objectUrlRef = useRef<null | string>(null);
|
const objectUrlRef = useRef<null | string>(null);
|
||||||
const onFetchErrorRef = useRef(onFetchError);
|
const onFetchErrorRef = useRef(onFetchError);
|
||||||
|
const requestRef = useRef(request);
|
||||||
const [state, setState] = useState<NativeImageState>({ status: 'idle' });
|
const [state, setState] = useState<NativeImageState>({ status: 'idle' });
|
||||||
|
|
||||||
|
requestRef.current = request;
|
||||||
|
|
||||||
const requestSignature = useMemo(() => {
|
const requestSignature = useMemo(() => {
|
||||||
if (!request) {
|
if (!request) {
|
||||||
return null;
|
return null;
|
||||||
@@ -44,6 +47,8 @@ export function useNativeImage({
|
|||||||
onFetchErrorRef.current = onFetchError;
|
onFetchErrorRef.current = onFetchError;
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
|
const request = requestRef.current;
|
||||||
|
|
||||||
const abortCurrentRequest = () => {
|
const abortCurrentRequest = () => {
|
||||||
abortControllerRef.current?.abort();
|
abortControllerRef.current?.abort();
|
||||||
abortControllerRef.current = null;
|
abortControllerRef.current = null;
|
||||||
@@ -62,28 +67,61 @@ export function useNativeImage({
|
|||||||
if (!request || !requestSignature) {
|
if (!request || !requestSignature) {
|
||||||
abortCurrentRequest();
|
abortCurrentRequest();
|
||||||
revokeObjectUrl();
|
revokeObjectUrl();
|
||||||
setState({ status: 'idle' });
|
setState((currentState) => {
|
||||||
|
if (currentState.status === 'idle' && !currentState.displaySrc) {
|
||||||
|
return currentState;
|
||||||
|
}
|
||||||
|
|
||||||
|
return { status: 'idle' };
|
||||||
|
});
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!enabled) {
|
if (!enabled) {
|
||||||
abortCurrentRequest();
|
abortCurrentRequest();
|
||||||
setState((currentState) =>
|
setState((currentState) => {
|
||||||
currentState.displaySrc
|
if (currentState.displaySrc) {
|
||||||
? { ...currentState, status: 'loaded' }
|
if (currentState.status === 'loaded') {
|
||||||
: { status: 'idle' },
|
return currentState;
|
||||||
);
|
}
|
||||||
|
|
||||||
|
return { ...currentState, status: 'loaded' };
|
||||||
|
}
|
||||||
|
|
||||||
|
if (currentState.status === 'idle' && !currentState.displaySrc) {
|
||||||
|
return currentState;
|
||||||
|
}
|
||||||
|
|
||||||
|
return { status: 'idle' };
|
||||||
|
});
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (loadedRequestSignatureRef.current === requestSignature && objectUrlRef.current) {
|
if (loadedRequestSignatureRef.current === requestSignature && objectUrlRef.current) {
|
||||||
setState({ displaySrc: objectUrlRef.current, status: 'loaded' });
|
const cachedObjectUrl = objectUrlRef.current;
|
||||||
|
|
||||||
|
setState((currentState) => {
|
||||||
|
if (
|
||||||
|
currentState.status === 'loaded' &&
|
||||||
|
currentState.displaySrc === cachedObjectUrl
|
||||||
|
) {
|
||||||
|
return currentState;
|
||||||
|
}
|
||||||
|
|
||||||
|
return { displaySrc: cachedObjectUrl, status: 'loaded' };
|
||||||
|
});
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
abortCurrentRequest();
|
abortCurrentRequest();
|
||||||
revokeObjectUrl();
|
revokeObjectUrl();
|
||||||
setState({ status: 'loading' });
|
setState((currentState) => {
|
||||||
|
if (currentState.status === 'loading' && !currentState.displaySrc) {
|
||||||
|
return currentState;
|
||||||
|
}
|
||||||
|
|
||||||
|
return { status: 'loading' };
|
||||||
|
});
|
||||||
|
|
||||||
const abortController = new AbortController();
|
const abortController = new AbortController();
|
||||||
abortControllerRef.current = abortController;
|
abortControllerRef.current = abortController;
|
||||||
@@ -138,7 +176,7 @@ export function useNativeImage({
|
|||||||
abortControllerRef.current = null;
|
abortControllerRef.current = null;
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
}, [enabled, fetchPriority, request, requestSignature]);
|
}, [enabled, fetchPriority, requestSignature]);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
return () => {
|
return () => {
|
||||||
|
|||||||
Reference in New Issue
Block a user