From 3f9fa0b208b2f423e0d9fde23109a05d4a81a7c5 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Fri, 10 Jul 2026 22:25:59 -0700
Subject: [PATCH] additional type fix for album group

---
 .../components/album-group-metadata-config.tsx      | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/renderer/features/shared/components/album-group-metadata-config.tsx b/src/renderer/features/shared/components/album-group-metadata-config.tsx
index 97fcb0498..faa033d07 100644
--- a/src/renderer/features/shared/components/album-group-metadata-config.tsx
+++ b/src/renderer/features/shared/components/album-group-metadata-config.tsx
@@ -23,10 +23,10 @@ const ALBUM_GROUP_ITEM_LABELS: Array<[AlbumGroupItem, string]> = [
     [AlbumGroupItem.SIZE, 'table.column.size'],
 ];
 
-const mergeItems = (
-    items: SortableItem<AlbumGroupItem>[],
-    itemLabels: Array<[string, string]>,
-): SortableItem<AlbumGroupItem>[] => {
+const mergeItems = <K extends string, T extends SortableItem<K>>(
+    items: T[],
+    itemLabels: Array<[K, string]>,
+): T[] => {
     const allItemIds = itemLabels.map(([key]) => key);
 
     const missingItemIds = allItemIds.filter((id) => !items.some((item) => item.id === id));
@@ -36,7 +36,7 @@ const mergeItems = (
         ...(missingItemIds.map((id) => ({
             disabled: true,
             id,
-        })) as SortableItem<AlbumGroupItem>[]),
+        })) as T[]),
     ];
 
     const uniqueMerged = merged.filter(
@@ -52,7 +52,8 @@ export const AlbumGroupMetadataConfig = memo(() => {
     const { setAlbumGroupItems } = useSettingsStoreActions();
 
     const items = useMemo(
-        () => mergeItems(albumGroupItems, ALBUM_GROUP_ITEM_LABELS),
+        () =>
+            mergeItems(albumGroupItems as SortableItem<AlbumGroupItem>[], ALBUM_GROUP_ITEM_LABELS),
         [albumGroupItems],
     );