From 355257104d5b41bfdd9a065e7d7f3c12f23e5778 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Tue, 2 Dec 2025 20:25:42 -0800
Subject: [PATCH] reorganize external link settings

---
 .../general/application-settings.tsx          | 20 +++++++
 .../components/general/control-settings.tsx   | 58 -------------------
 2 files changed, 20 insertions(+), 58 deletions(-)

diff --git a/src/renderer/features/settings/components/general/application-settings.tsx b/src/renderer/features/settings/components/general/application-settings.tsx
index 0d4226f14..3cbc330d8 100644
--- a/src/renderer/features/settings/components/general/application-settings.tsx
+++ b/src/renderer/features/settings/components/general/application-settings.tsx
@@ -491,6 +491,26 @@ export const ApplicationSettings = () => {
             isHidden: false,
             title: t('setting.sidePlayQueueStyle', { postProcess: 'sentenceCase' }),
         },
+        {
+            control: (
+                <Switch
+                    defaultChecked={settings.externalLinks}
+                    onChange={(e) => {
+                        setSettings({
+                            general: {
+                                ...settings,
+                                externalLinks: e.currentTarget.checked,
+                            },
+                        });
+                    }}
+                />
+            ),
+            description: t('setting.externalLinks', {
+                context: 'description',
+                postProcess: 'sentenceCase',
+            }),
+            title: t('setting.externalLinks', { postProcess: 'sentenceCase' }),
+        },
         {
             control: (
                 <Switch
diff --git a/src/renderer/features/settings/components/general/control-settings.tsx b/src/renderer/features/settings/components/general/control-settings.tsx
index 5acb75f7b..ea9d4d0ff 100644
--- a/src/renderer/features/settings/components/general/control-settings.tsx
+++ b/src/renderer/features/settings/components/general/control-settings.tsx
@@ -6,7 +6,6 @@ import {
 } from '/@/renderer/features/settings/components/settings-section';
 import {
     BarAlign,
-    GenreTarget,
     PlayerbarSliderType,
     useGeneralSettings,
     usePlayerbarSlider,
@@ -233,63 +232,6 @@ export const ControlSettings = () => {
             isHidden: false,
             title: t('setting.volumeWidth', { postProcess: 'sentenceCase' }),
         },
-
-        {
-            control: (
-                <Switch
-                    defaultChecked={settings.externalLinks}
-                    onChange={(e) => {
-                        setSettings({
-                            general: {
-                                ...settings,
-                                externalLinks: e.currentTarget.checked,
-                            },
-                        });
-                    }}
-                />
-            ),
-            description: t('setting.externalLinks', {
-                context: 'description',
-                postProcess: 'sentenceCase',
-            }),
-            title: t('setting.externalLinks', { postProcess: 'sentenceCase' }),
-        },
-
-        {
-            control: (
-                <Select
-                    data={[
-                        {
-                            label: t('entity.album_other', {
-                                postProcess: 'titleCase',
-                            }),
-                            value: GenreTarget.ALBUM,
-                        },
-                        {
-                            label: t('entity.track_other', {
-                                postProcess: 'titleCase',
-                            }),
-                            value: GenreTarget.TRACK,
-                        },
-                    ]}
-                    defaultValue={settings.genreTarget}
-                    onChange={(e) =>
-                        setSettings({
-                            general: {
-                                ...settings,
-                                genreTarget: e as GenreTarget,
-                            },
-                        })
-                    }
-                />
-            ),
-            description: t('setting.genreBehavior', {
-                context: 'description',
-                postProcess: 'sentenceCase',
-            }),
-            isHidden: false,
-            title: t('setting.genreBehavior', { postProcess: 'sentenceCase' }),
-        },
         {
             control: (
                 <SegmentedControl